Unified Diff: mobile/android/base/resources/xml-v11/preferences.xml
Issue 4920541991403520:
Create a minimal settings UI (Closed)
Patch Set: Cleanup of AddOnBridge
Created March 22, 2015, 12:13 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« mobile/android/base/moz.build ('K')
|
« mobile/android/base/moz.build ('k')
|
mobile/android/base/resources/xml-v11/preferences_abp_adblockplus.xml » ('j')
|
mobile/android/base/resources/xml-v11/preferences_abp_adblockplus.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: mobile/android/base/resources/xml-v11/preferences.xml |
| diff --git a/mobile/android/base/resources/xml-v11/preferences.xml b/mobile/android/base/resources/xml-v11/preferences.xml |
| index 8dffcbfc4de097ca0d259f773f9a383711ec750a..8566c238118ccd1f63fcb744e18dad68a2a7f165 100644 |
| --- a/mobile/android/base/resources/xml-v11/preferences.xml |
| +++ b/mobile/android/base/resources/xml-v11/preferences.xml |
| @@ -34,6 +34,13 @@ |
| android:value="preferences_privacy" /> |
| </PreferenceScreen> |
| + <!-- Adblock Plus Browser preferences --> |
|
Felix Dahlke
2015/03/22 13:52:34
"Adblocking preferences", I'd say.
René Jeschke
2015/03/22 15:32:59
Done.
|
| + <PreferenceScreen android:title="@string/abp_pref_category_adblocking" |
|
Felix Dahlke
2015/03/22 13:52:34
So you're planning to prefix all of our strings wi
René Jeschke
2015/03/22 15:32:59
Because abp is shorter, but, ok, will use 'adblock
|
| + android:fragment="org.mozilla.gecko.preferences.GeckoPreferenceFragment" > |
| + <extra android:name="resource" |
| + android:value="preferences_abp_adblockplus" /> |
|
Felix Dahlke
2015/03/22 13:52:34
Why not "preferences_adblocking"?
René Jeschke
2015/03/22 15:32:59
Because we have a sub-preference that is called 'A
Felix Dahlke
2015/03/22 15:51:45
Doesn't really make sense - these are the adblocki
|
| + </PreferenceScreen> |
| + |
| <PreferenceScreen android:title="@string/pref_category_language" |
| android:fragment="org.mozilla.gecko.preferences.GeckoPreferenceFragment" > |
| <extra android:name="resource" |
