Issue 4949324312084480: Issue 2323 - Resolve links automatically in templates as well

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4949324312084480: Issue 2323 - Resolve links automatically in templates as well (Closed)

Created:
April 20, 2015, 11:41 a.m. by Wladimir Palant

Modified:
April 20, 2015, 11:50 a.m.

Reviewers:
Sebastian Noack

Visibility:
Public.

Description

This is supposed to be applied after https://hg.adblockplus.org/cms/rev/4db7e0c3d360 is backed out. Explicitly specifying links to be resolved seems overly complicated and inconsistent with other converters. Also, currently it doesn`t work for images at all. So after some consideration I thought that automatic resolution is a better approach after all.

Patch Set 1 #

Total comments: 2

Created: April 20, 2015, 11:41 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	cms/converters.py	View		1 chunk	+4 lines, -1 line	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Sebastian Noack

http://codereview.adblockplus.org/4949324312084480/diff/5629499534213120/cms/converters.py File cms/converters.py (right): http://codereview.adblockplus.org/4949324312084480/diff/5629499534213120/cms/converters.py#newcode334 cms/converters.py:334: result = unicode(module) Nit: I'd rather chain the function ...

April 20, 2015, 11:47 a.m. (2015-04-20 11:47:38 UTC) #2

Wladimir Palant

April 20, 2015, 11:50 a.m. (2015-04-20 11:50:37 UTC) #3

http://codereview.adblockplus.org/4949324312084480/diff/5629499534213120/cms/...
File cms/converters.py (right):

http://codereview.adblockplus.org/4949324312084480/diff/5629499534213120/cms/...
cms/converters.py:334: result = unicode(module)
On 2015/04/20 11:47:38, Sebastian Noack wrote:
> Nit: I'd rather chain the function calls instead introducing a bogus return
> value variable:

I'd rather keep it this way - the other generators are also built this way, with
multiple conversion steps.

Expand All Messages | Collapse All Messages