Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/JsValue.h

Issue 4949583905947648: Issue 1280 - Update v8, the second part (Closed)
Patch Set: Created Oct. 27, 2014, 10:01 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/AdblockPlus/JsEngine.h ('k') | include/AdblockPlus/V8ValueHolder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/JsValue.h
===================================================================
--- a/include/AdblockPlus/JsValue.h
+++ b/include/AdblockPlus/JsValue.h
@@ -18,18 +18,11 @@
#ifndef ADBLOCK_PLUS_JS_VALUE_H
#define ADBLOCK_PLUS_JS_VALUE_H
-#include <stdint.h>
+#include <cstdint>
#include <string>
#include <vector>
#include "tr1_memory.h"
-#include "V8ValueHolder.h"
-
-namespace v8
-{
- class Value;
- template<class T> class Handle;
- template<class T> class Local;
-}
+#include <v8.h>
namespace AdblockPlus
{
@@ -67,7 +60,7 @@
};
protected:
typedef Private::CtrArg PrivateCtrArg;
- JsValue(const JsValuePtr& value);
+ JsValue(JsValue&& src);
public:
JsValue(const JsEnginePtr& jsEngine, const v8::Handle<v8::Value> value, PrivateCtrArg);
virtual ~JsValue();
@@ -143,7 +136,7 @@
protected:
JsEnginePtr jsEngine;
private:
- V8ValueHolder<v8::Value> value;
+ v8::UniquePersistent<v8::Value> value;
};
}
« no previous file with comments | « include/AdblockPlus/JsEngine.h ('k') | include/AdblockPlus/V8ValueHolder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld