Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5037474598354944: Only reload the popover in Safari, when itself is shown for a different tab (Closed)

Created:
Dec. 27, 2013, 7:56 p.m. by Sebastian Noack
Modified:
Jan. 16, 2014, 11:39 a.m.
Visibility:
Public.

Description

I mistakenly assumed that there can only be one popover. And added an event listener that is called when any popover is shown, to all popovers, in order to reload the popover. However each browser window has its own instance of the popover/bubble. So this patch restricts the the event listener to the current popover.

Patch Set 1 #

Patch Set 2 : Reload the bubble only when it is shown for a different tab #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M safari/ext/popup.js View 1 2 chunks +15 lines, -7 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
Dec. 27, 2013, 8:03 p.m. (2013-12-27 20:03:11 UTC) #1
Wladimir Palant
LGTM
Jan. 13, 2014, 12:39 p.m. (2014-01-13 12:39:28 UTC) #2
Sebastian Noack
I have uploaded a new patchset, that also reloads the bubble only when it is ...
Jan. 15, 2014, 5:57 p.m. (2014-01-15 17:57:12 UTC) #3
Wladimir Palant
Jan. 16, 2014, 8:43 a.m. (2014-01-16 08:43:05 UTC) #4
Still LGTM

Powered by Google App Engine
This is Rietveld