Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5069344035831808: Issue 1193 - Fix thumbnails on youtube: do not hang blocked subdocument requests (Closed)

Created:
Aug. 12, 2014, 12:49 a.m. by Oleksandr
Modified:
Aug. 12, 2014, 10:30 p.m.
Reviewers:
sergei, Eric
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 1193 - Fix thumbnails on youtube: do not hang blocked subdocument requests

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/plugin/PluginWbPassThrough.cpp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 2
Oleksandr
http://codereview.adblockplus.org/5069344035831808/diff/5629499534213120/src/plugin/PluginWbPassThrough.cpp File src/plugin/PluginWbPassThrough.cpp (left): http://codereview.adblockplus.org/5069344035831808/diff/5629499534213120/src/plugin/PluginWbPassThrough.cpp#oldcode259 src/plugin/PluginWbPassThrough.cpp:259: m_spInternetProtocolSink->ReportResult(INET_E_REDIRECTING, 301, L"res://mshtml.dll/blank.htm"); The behavior here changed after the ...
Aug. 12, 2014, 12:56 a.m. (2014-08-12 00:56:57 UTC) #1
Eric
Aug. 12, 2014, 1:09 a.m. (2014-08-12 01:09:41 UTC) #2
LGTM.

I have to disclaim that I don't know why it works, but the change isn't
obviously bad in any way I see.

Powered by Google App Engine
This is Rietveld