safari/ext/popup.js - Issue 5083364310646784: Got rid of strange animation when the bubble is resized while reloading on Safari

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: safari/ext/popup.js

Issue 5083364310646784: Got rid of strange animation when the bubble is resized while reloading on Safari (Closed)

Patch Set: Addressed comment Created Jan. 17, 2014, noon

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: safari/ext/popup.js

===================================================================

--- a/safari/ext/popup.js

+++ b/safari/ext/popup.js

@@ -9,11 +9,13 @@

var backgroundPage = safari.extension.globalPage.contentWindow;

var readyState = backgroundPage.document.readyState;

var activeTab = safari.application.activeBrowserWindow.activeTab;

+ var mayResize = true;

safari.self.addEventListener("popover", function()

{

if (activeTab != safari.application.activeBrowserWindow.activeTab || readyState != "complete")

{

+ mayResize = false;

document.documentElement.style.display = "none";

document.location.reload();

}

@@ -25,8 +27,11 @@

// event listeners to do so.

var updateSize = function()

{

- safari.self.width = document.body.offsetWidth;

- safari.self.height = document.body.offsetHeight;

+ if (mayResize)

+ {

+ safari.self.width = document.body.offsetWidth;

+ safari.self.height = document.body.offsetHeight;

+ ]

};

window.addEventListener("load", function()

« no previous file with comments | « no previous file | no next file » | no next file with comments »