Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5110636153405440: Issue 130 - Add a README.md to the adblockplus repository (Closed)

Created:
July 18, 2014, 11:41 a.m. by Felix Dahlke
Modified:
July 18, 2014, 1:37 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 130 - Add a README.md to the adblockplus repository Contrary to what the issue says, I decided to explain how to run the tests here. Otherwise people won't know how to use the prebuilt test extension.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Did some hard wrapping after all, addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
A README.md View 1 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Felix Dahlke
July 18, 2014, 11:45 a.m. (2014-07-18 11:45:44 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/5110636153405440/diff/5629499534213120/README.md File README.md (right): http://codereview.adblockplus.org/5110636153405440/diff/5629499534213120/README.md#newcode18 README.md:18: This will create a build with a name in ...
July 18, 2014, 11:55 a.m. (2014-07-18 11:55:22 UTC) #2
Wladimir Palant
LGTM with the issues below resolved. http://codereview.adblockplus.org/5110636153405440/diff/5629499534213120/README.md File README.md (right): http://codereview.adblockplus.org/5110636153405440/diff/5629499534213120/README.md#newcode18 README.md:18: This will create ...
July 18, 2014, 12:58 p.m. (2014-07-18 12:58:10 UTC) #3
Felix Dahlke
Uploaded a new patch set.
July 18, 2014, 1:16 p.m. (2014-07-18 13:16:30 UTC) #4
Wladimir Palant
July 18, 2014, 1:28 p.m. (2014-07-18 13:28:18 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld