Issue 5115653975441408: Let popup reload when it is shown, after it was programatically closed, on Safari

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5115653975441408: Let popup reload when it is shown, after it was programatically closed, on Safari (Closed)

Created:
Jan. 17, 2014, 11:38 a.m. by Sebastian Noack

Modified:
Jan. 17, 2014, 3:02 p.m.

Reviewers:
Felix Dahlke, Wladimir Palant

CC:
Thomas Greiner

Visibility:
Public.

Description

window.close() doesn't work in the popover on Safari. So we had to use safari.self.hide() instead, see http://codereview.adblockplus.org/5768552254537728/. However this isn't really the same. It just hides the popover and will show it again with the same state, when you click the toolbar item again. So we also have to make sure that the bubble is reloaded when it is shown the next time.

Patch Set 1 #

Created: Jan. 17, 2014, 11:38 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	safari/ext/popup.js	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages