Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5117917230268416: No issue - remove dead code (Closed)

Created:
Oct. 8, 2014, 2:46 p.m. by sergei
Modified:
Oct. 13, 2014, 9:27 a.m.
Visibility:
Public.

Description

- get rid of file src/plugin/PluginDomTraverser.h because it's pointless - remove free function `CreateLowProcess` from src\plugin\PluginClass.cpp. It's not used and obsolete. - get rid of CPluginDomTraverserCacheBase::ShowNotification method, it's not used and the body is pointless

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -130 lines) Patch
M adblockplus.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/plugin/PluginClass.cpp View 1 chunk +0 lines, -110 lines 0 comments Download
R src/plugin/PluginDomTraverser.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/plugin/PluginDomTraverserBase.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/plugin/PluginTabBase.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
sergei
Oct. 8, 2014, 3:07 p.m. (2014-10-08 15:07:38 UTC) #1
Eric
LGTM. I would recommend, however, adding some descriptive text to the commit message.
Oct. 8, 2014, 5:05 p.m. (2014-10-08 17:05:03 UTC) #2
Oleksandr
Oct. 8, 2014, 7:13 p.m. (2014-10-08 19:13:45 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld