issue 47 - use WeakMap instead of setUserData and getUserData methods

lib/requestNotifier.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 11 matching lines @@
 Cu.import("resource://gre/modules/Services.jsm");
 
 let {Utils} = require("utils");
 let {BlockingFilter, WhitelistFilter, ElemHideBase, ElemHideFilter, ElemHideException} = require("filterClasses");
 
 let nodeData = new WeakMap();
 let windowStats = new WeakMap();
 let windowSelection = new WeakMap();
 
 let setEntry, hasEntry, getEntry;
-if (false)
+// Last issue(Bug 982561) preventing us from using WeakMap fixed for FF version 32
+if (Services.vc.compare(Utils.platformVersion, "32.0a1") >= 0)
 {
-  // This branch can be enabled again once all of bug 673468, bug 819131 and
-  // bug 982561 are fixed and we can use weak maps.
   setEntry = function(map, key, value) map.set(key, value);
   hasEntry = function(map, key) map.has(key);
   getEntry = function(map, key) map.get(key);
 }
 else
 {
   // Fall back to user data
   let dataSeed = Math.random();
   let nodeDataProp = "abpNodeData" + dataSeed;
   let windowStatsProp = "abpWindowStats" + dataSeed;
@@ skipping 318 matching lines @@
     if (typeof existingData == "undefined")
     {
       existingData = {};
       setEntry(nodeData, node, existingData);
     }
 
     // Add this request to the node data
     existingData[this.type + " " + this.location] = this;
   }
 };