Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5121634776121344: Issue 2049 - Wrong logo being displayed in Options and Block Element dialog (Closed)

Created:
Feb. 26, 2015, 9 p.m. by Wladimir Palant
Modified:
March 2, 2015, 11:21 a.m.
Visibility:
Public.

Description

Issue 2049 - Wrong logo being displayed in Options and Block Element dialog

Patch Set 1 #

Total comments: 11

Patch Set 2 : Removed redundant descriptors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M background.js View 1 chunk +1 line, -1 line 0 comments Download
M block.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/icons/detailed/abp-48.png View Binary file 0 comments Download
M icons/detailed/abp-128.png View Binary file 0 comments Download
A icons/detailed/abp-32.png View Binary file 0 comments Download
M icons/detailed/abp-64.png View Binary file 0 comments Download
M metadata.chrome View 2 chunks +3 lines, -2 lines 0 comments Download
M metadata.safari View 1 chunk +1 line, -1 line 0 comments Download
M options.html View 1 1 chunk +1 line, -1 line 0 comments Download
M popup.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13
Wladimir Palant
Feb. 26, 2015, 9 p.m. (2015-02-26 21:00:30 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html File block.html (right): http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html#newcode75 block.html:75: <img src="icons/detailed/abp-32.png" srcset="icons/detailed/abp-32.png 1x, icons/detailed/abp-64.png 2x"> Nit: redundant space ...
Feb. 27, 2015, 12:49 p.m. (2015-02-27 12:49:42 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html File block.html (right): http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html#newcode75 block.html:75: <img src="icons/detailed/abp-32.png" srcset="icons/detailed/abp-32.png 1x, icons/detailed/abp-64.png 2x"> On 2015/02/27 12:49:42, ...
Feb. 27, 2015, 6:46 p.m. (2015-02-27 18:46:20 UTC) #3
Sebastian Noack
http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html File block.html (right): http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html#newcode75 block.html:75: <img src="icons/detailed/abp-32.png" srcset="icons/detailed/abp-32.png 1x, icons/detailed/abp-64.png 2x"> On 2015/02/27 18:46:20, ...
Feb. 27, 2015, 6:53 p.m. (2015-02-27 18:53:12 UTC) #4
Wladimir Palant
http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html File block.html (right): http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html#newcode75 block.html:75: <img src="icons/detailed/abp-32.png" srcset="icons/detailed/abp-32.png 1x, icons/detailed/abp-64.png 2x"> On 2015/02/27 18:53:12, ...
Feb. 27, 2015, 7:04 p.m. (2015-02-27 19:04:30 UTC) #5
Wladimir Palant
http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html File block.html (right): http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html#newcode75 block.html:75: <img src="icons/detailed/abp-32.png" srcset="icons/detailed/abp-32.png 1x, icons/detailed/abp-64.png 2x"> Ok, it seems ...
Feb. 27, 2015, 7:11 p.m. (2015-02-27 19:11:16 UTC) #6
Sebastian Noack
http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html File block.html (right): http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html#newcode75 block.html:75: <img src="icons/detailed/abp-32.png" srcset="icons/detailed/abp-32.png 1x, icons/detailed/abp-64.png 2x"> On 2015/02/27 19:04:30, ...
Feb. 27, 2015, 7:16 p.m. (2015-02-27 19:16:01 UTC) #7
Sebastian Noack
http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html File block.html (right): http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html#newcode75 block.html:75: <img src="icons/detailed/abp-32.png" srcset="icons/detailed/abp-32.png 1x, icons/detailed/abp-64.png 2x"> On 2015/02/27 19:11:17, ...
Feb. 27, 2015, 7:18 p.m. (2015-02-27 19:18:37 UTC) #8
Wladimir Palant
http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html File block.html (right): http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html#newcode75 block.html:75: <img src="icons/detailed/abp-32.png" srcset="icons/detailed/abp-32.png 1x, icons/detailed/abp-64.png 2x"> On 2015/02/27 19:18:37, ...
Feb. 27, 2015, 7:26 p.m. (2015-02-27 19:26:59 UTC) #9
Sebastian Noack
LGTM http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html File block.html (right): http://codereview.adblockplus.org/5121634776121344/diff/5629499534213120/block.html#newcode75 block.html:75: <img src="icons/detailed/abp-32.png" srcset="icons/detailed/abp-32.png 1x, icons/detailed/abp-64.png 2x"> On 2015/02/27 ...
Feb. 27, 2015, 7:29 p.m. (2015-02-27 19:29:56 UTC) #10
Sebastian Noack
I missed one more thing. For consistency, the chrome/icons/abp-48.png should be moved to chrome/icons/detailed/abp-48.png.
Feb. 28, 2015, 9:19 a.m. (2015-02-28 09:19:04 UTC) #11
Sebastian Noack
On 2015/02/28 09:19:04, Sebastian Noack wrote: > I missed one more thing. For consistency, the ...
Feb. 28, 2015, 9:19 a.m. (2015-02-28 09:19:44 UTC) #12
Thomas Greiner
March 2, 2015, 11:07 a.m. (2015-03-02 11:07:56 UTC) #13
LGTM

Powered by Google App Engine
This is Rietveld