Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: block.html

Issue 5121634776121344: Issue 2049 - Wrong logo being displayed in Options and Block Element dialog (Closed)
Patch Set: Created Feb. 26, 2015, 9 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « background.js ('k') | chrome/icons/detailed/abp-48.png » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 2
3 <!-- 3 <!--
4 - This file is part of Adblock Plus <https://adblockplus.org/>, 4 - This file is part of Adblock Plus <https://adblockplus.org/>,
5 - Copyright (C) 2006-2015 Eyeo GmbH 5 - Copyright (C) 2006-2015 Eyeo GmbH
6 - 6 -
7 - Adblock Plus is free software: you can redistribute it and/or modify 7 - Adblock Plus is free software: you can redistribute it and/or modify
8 - it under the terms of the GNU General Public License version 3 as 8 - it under the terms of the GNU General Public License version 3 as
9 - published by the Free Software Foundation. 9 - published by the Free Software Foundation.
10 - 10 -
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 } 65 }
66 button 66 button
67 { 67 {
68 padding: 3px !important; 68 padding: 3px !important;
69 } 69 }
70 </style> 70 </style>
71 </head> 71 </head>
72 <body draggable="true"> 72 <body draggable="true">
73 73
74 <div id="title"> 74 <div id="title">
75 <img src="icons/abp-32.png" /> 75 <img src="icons/detailed/abp-32.png" srcset="icons/detailed/abp-32.png 1x, ic ons/detailed/abp-64.png 2x">
Sebastian Noack 2015/02/27 12:49:42 Nit: redundant space before "srcset".
Sebastian Noack 2015/02/27 12:49:42 Nit: You don't need to redundantly specify the org
Sebastian Noack 2015/02/27 12:49:42 How about specifying the abp-48.png for 1.5x?
Wladimir Palant 2015/02/27 18:46:20 I verified that this indeed matches the current im
Sebastian Noack 2015/02/27 18:53:12 This isn't about screens, but about operating syst
Wladimir Palant 2015/02/27 19:04:30 The point is: 1.5x is an uncommon setting, there a
Wladimir Palant 2015/02/27 19:11:17 Ok, it seems that Wikipedia will produce a differe
Sebastian Noack 2015/02/27 19:16:01 Sure 2x is way more common. But if we have a match
Sebastian Noack 2015/02/27 19:18:37 Are you talking about the few bytes we would add b
Wladimir Palant 2015/02/27 19:26:59 If we support a particular pixel density, we shoul
Sebastian Noack 2015/02/27 19:29:56 Fair enough.
76 <span class="i18n_add_filters_msg"></span> 76 <span class="i18n_add_filters_msg"></span>
77 </div> 77 </div>
78 78
79 <textarea id="filters"></textarea> 79 <textarea id="filters"></textarea>
80 80
81 <div id="buttons"> 81 <div id="buttons">
82 <button id="addButton" class="i18n_add"></button> 82 <button id="addButton" class="i18n_add"></button>
83 <button id="cancelButton" class="i18n_cancel"></button> 83 <button id="cancelButton" class="i18n_cancel"></button>
84 </div> 84 </div>
85 85
86 </body> 86 </body>
87 </html> 87 </html>
OLDNEW
« no previous file with comments | « background.js ('k') | chrome/icons/detailed/abp-48.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld