Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5127392146227200: Issue 2478 - Disable crash reporting (Closed)

Created:
May 8, 2015, 4:57 p.m. by René Jeschke
Modified:
May 28, 2015, 7:30 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Issue 2478 - Disable crash reporting

Patch Set 1 #

Total comments: 5

Patch Set 2 : Follow-up issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M README.md View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4
René Jeschke
May 8, 2015, 4:58 p.m. (2015-05-08 16:58:20 UTC) #1
Felix Dahlke
Could you file a follow-up issue for this and link to it in the README? ...
May 8, 2015, 8:07 p.m. (2015-05-08 20:07:22 UTC) #2
René Jeschke
http://codereview.adblockplus.org/5127392146227200/diff/5629499534213120/README.md File README.md (right): http://codereview.adblockplus.org/5127392146227200/diff/5629499534213120/README.md#newcode14 README.md:14: Important note On 2015/05/08 20:07:22, Felix H. Dahlke wrote: ...
May 11, 2015, 12:10 p.m. (2015-05-11 12:10:53 UTC) #3
Felix Dahlke
May 11, 2015, 4:07 p.m. (2015-05-11 16:07:48 UTC) #4
LGTM

http://codereview.adblockplus.org/5127392146227200/diff/5629499534213120/READ...
File README.md (right):

http://codereview.adblockplus.org/5127392146227200/diff/5629499534213120/READ...
README.md:17: You must add the following line to your `mozconfig`:
On 2015/05/11 12:10:54, René Jeschke wrote:
> On 2015/05/08 20:07:22, Felix H. Dahlke wrote:
> > It's .mozconfig.
> 
> It's 'mozconfig':
> https://wiki.mozilla.org/Mobile/Fennec/Android#Preparing_a_Fennec_mozconfig

Alright :)

Powered by Google App Engine
This is Rietveld