Unified Diff: popupBlocker.js
Issue 5133183649579008:
Fixed: Popup blocking functionality broken (Closed)
Patch Set: Removed ext.webNavigation implementation
Created Dec. 20, 2013, 4:19 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: popupBlocker.js |
| =================================================================== |
| --- a/popupBlocker.js |
| +++ b/popupBlocker.js |
| @@ -21,10 +21,11 @@ |
| chrome.webNavigation.onCreatedNavigationTarget.addListener(function(details) |
| { |
| - if (isFrameWhitelisted(details.sourceTabId, details.sourceFrameId)) |
| + var sourceTab = new Tab({id: details.sourceTabId}); |
| + if (isFrameWhitelisted(sourceTab, details.sourceFrameId)) |
| return; |
| - var openerUrl = getFrameUrl(details.sourceTabId, details.sourceFrameId); |
| + var openerUrl = getFrameUrl(sourceTab, details.sourceFrameId); |
| if (!openerUrl) |
| { |
| // We don't know the opener tab |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
