Issue 98 - Use the libadblockplus update mechanism

src/org/adblockplus/android/AndroidUpdateCheckDoneCallback.java

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 package org.adblockplus.android;
 
 import org.adblockplus.libadblockplus.UpdateCheckDoneCallback;
 import org.apache.commons.lang.StringUtils;
 
-import android.app.Notification;
-import android.app.NotificationManager;
 import android.content.Context;
+import android.util.Log;
 
 public class AndroidUpdateCheckDoneCallback extends UpdateCheckDoneCallback
 {
   private final Context context;
 
   public AndroidUpdateCheckDoneCallback(final Context context)
   {
     this.context = context;
   }
 
   @Override
   public void updateCheckDoneCallback(final String error)
   {
-    // TODO: Check if we need this 'manualUpdate' mechanism (initiated by 'checkForUpdates()')
-    // if (!error.empty())
-    // {
-    // jstring jError = jniEnv->NewStringUTF(error.c_str());
-    // if (mid)
-    // jniEnv->CallVoidMethod(jniObject, mid, NULL, jError);
-    // jniEnv->DeleteLocalRef(jError);
-    // }
-    // else if (manualUpdate)
-    // {
-    // if (mid)
-    // jniEnv->CallVoidMethod(jniObject, mid, NULL, NULL);
-    // }
-
-    final Notification notification = Utils.createUpdateNotification(this.context, null, StringUtils.isEmpty(error) ? null : error);
-    final NotificationManager notificationManager = (NotificationManager)this.context.getSystemService(Context.NOTIFICATION_SERVICE);
-    notificationManager.notify(AdblockPlus.UPDATE_NOTIFICATION_ID, notification);
+    if (StringUtils.isEmpty(error))
+      return;
+    Log.e(Utils.getTag(AndroidUpdateCheckDoneCallback.class), "Update check failed: " + error);

[René Jeschke, 2014/09/26 13:10:52]

Could you please extract the 'tag' into a private/static/class variable? It's
commonly used in all classes throughout the project, like:

  private static final String TAG =
Utils.getTag(AndroidUpdateCheckDoneCallback.class);

[Felix Dahlke, 2014/09/26 13:15:31]

Done.

+    Utils.showUpdateNotification(this.context, null, error);
   }
 }