Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: src/plugin/AdblockPlusClient.h

Issue 5163396739629056: Issue #1234 - Remove CString from ShouldBlock(), IsElementHidden() declarations (Closed)
Patch Set: Created Sept. 30, 2014, 5:37 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/plugin/AdblockPlusClient.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #ifndef _ADBLOCK_PLUS_CLIENT_H_ 1 #ifndef _ADBLOCK_PLUS_CLIENT_H_
2 #define _ADBLOCK_PLUS_CLIENT_H_ 2 #define _ADBLOCK_PLUS_CLIENT_H_
3 3
4 4
5 #include "PluginTypedef.h" 5 #include "PluginTypedef.h"
6 #include "PluginClientBase.h" 6 #include "PluginClientBase.h"
7 #include "../shared/Communication.h" 7 #include "../shared/Communication.h"
8 #include "../shared/CriticalSection.h" 8 #include "../shared/CriticalSection.h"
9 9
10 10
(...skipping 10 matching lines...) Expand all
21 class CAdblockPlusClient : public CPluginClientBase 21 class CAdblockPlusClient : public CPluginClientBase
22 { 22 {
23 23
24 private: 24 private:
25 25
26 std::auto_ptr<CPluginFilter> m_filter; 26 std::auto_ptr<CPluginFilter> m_filter;
27 27
28 CComAutoCriticalSection m_criticalSectionFilter; 28 CComAutoCriticalSection m_criticalSectionFilter;
29 CComAutoCriticalSection m_criticalSectionCache; 29 CComAutoCriticalSection m_criticalSectionCache;
30 30
31 std::map<CString,bool> m_cacheBlockedSources; 31 std::map<std::wstring, bool> m_cacheBlockedSources;
32 32
33 std::shared_ptr<Communication::Pipe> enginePipe; 33 std::shared_ptr<Communication::Pipe> enginePipe;
34 CriticalSection enginePipeLock; 34 CriticalSection enginePipeLock;
35 35
36 36
37 // Private constructor used by the singleton pattern 37 // Private constructor used by the singleton pattern
38 CAdblockPlusClient(); 38 CAdblockPlusClient();
39 39
40 bool CallEngine(Communication::OutputBuffer& message, Communication::InputBuff er& inputBuffer = Communication::InputBuffer()); 40 bool CallEngine(Communication::OutputBuffer& message, Communication::InputBuff er& inputBuffer = Communication::InputBuffer());
41 bool CallEngine(Communication::ProcType proc, Communication::InputBuffer& inpu tBuffer = Communication::InputBuffer()); 41 bool CallEngine(Communication::ProcType proc, Communication::InputBuffer& inpu tBuffer = Communication::InputBuffer());
42 public: 42 public:
43 43
44 static CAdblockPlusClient* s_instance; 44 static CAdblockPlusClient* s_instance;
45 45
46 ~CAdblockPlusClient(); 46 ~CAdblockPlusClient();
47 47
48 static CAdblockPlusClient* GetInstance(); 48 static CAdblockPlusClient* GetInstance();
49 49
50 // Removes the url from the list of whitelisted urls if present 50 // Removes the url from the list of whitelisted urls if present
51 // Only called from ui thread 51 // Only called from ui thread
52 bool ShouldBlock(CString src, int contentType, const CString& domain, bool add Debug=false); 52 bool ShouldBlock(const std::wstring& src, int contentType, const std::wstring& domain, bool addDebug=false);
53 53
54 bool IsElementHidden(const CString& tag, IHTMLElement* pEl, const CString& dom ain, const CString& indent, CPluginFilter* filter); 54 bool IsElementHidden(const std::wstring& tag, IHTMLElement* pEl, const std::ws tring& domain, const std::wstring& indent, CPluginFilter* filter);
55 bool IsWhitelistedUrl(const std::wstring& url); 55 bool IsWhitelistedUrl(const std::wstring& url);
56 bool IsElemhideWhitelistedOnDomain(const std::wstring& url); 56 bool IsElemhideWhitelistedOnDomain(const std::wstring& url);
57 57
58 int GetIEVersion(); 58 int GetIEVersion();
59 59
60 bool Matches(const std::wstring& url, const std::wstring& contentType, const s td::wstring& domain); 60 bool Matches(const std::wstring& url, const std::wstring& contentType, const s td::wstring& domain);
61 std::vector<std::wstring> GetElementHidingSelectors(const std::wstring& domain ); 61 std::vector<std::wstring> GetElementHidingSelectors(const std::wstring& domain );
62 std::vector<SubscriptionDescription> FetchAvailableSubscriptions(); 62 std::vector<SubscriptionDescription> FetchAvailableSubscriptions();
63 std::vector<SubscriptionDescription> GetListedSubscriptions(); 63 std::vector<SubscriptionDescription> GetListedSubscriptions();
64 bool IsAcceptableAdsEnabled(); 64 bool IsAcceptableAdsEnabled();
(...skipping 15 matching lines...) Expand all
80 std::wstring GetAppLocale(); 80 std::wstring GetAppLocale();
81 std::wstring GetDocumentationLink(); 81 std::wstring GetDocumentationLink();
82 bool TogglePluginEnabled(); 82 bool TogglePluginEnabled();
83 std::wstring GetHostFromUrl(const std::wstring& url); 83 std::wstring GetHostFromUrl(const std::wstring& url);
84 int CompareVersions(const std::wstring& v1, const std::wstring& v2); 84 int CompareVersions(const std::wstring& v1, const std::wstring& v2);
85 85
86 bool IsFirstRun(); 86 bool IsFirstRun();
87 }; 87 };
88 88
89 #endif // _ADBLOCK_PLUS_CLIENT_H_ 89 #endif // _ADBLOCK_PLUS_CLIENT_H_
OLDNEW
« no previous file with comments | « no previous file | src/plugin/AdblockPlusClient.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld