Issue 768 - Switch from TR1 to C++11

include/AdblockPlus/Notification.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #ifndef ADBLOCK_PLUS_NOTIFICATION_H
 #define ADBLOCK_PLUS_NOTIFICATION_H
 
 #include <string>
 #include <vector>
+#include <memory>
 

[Wladimir Palant, 2015/08/05 11:19:40]

You are assuming that <vector> will include <memory> internally. IMHO that's a
bad idea, you should just spell out your requirements explicitly without making
any assumptions.

[sergei, 2015/08/06 07:35:30]

Here the same, <memory> is not included by <vector>, it's included in cpp file
by another header before including of this header. Anyway, it's always good to
have all required headers to be included in the header.

[Wladimir Palant, 2015/08/06 12:24:54]

Ok, that's even worse then - very non-obvious and error-prone. Will you fix it?

[sergei, 2015/08/07 06:29:39]

Yes, sure.

 namespace AdblockPlus
 {
   class FilterEngine;
   /**
    * Possible notification types.
    */
   enum NotificationType
   {
     NOTIFICATION_TYPE_INFORMATION,
     NOTIFICATION_TYPE_QUESTION,
@@ skipping 45 matching lines @@
     void MarkAsShown();
   private:
     std::string title;
     std::string message;
     NotificationType type;
   };
   typedef std::shared_ptr<Notification> NotificationPtr;
 }
 
 #endif