background.js - Issue 5171007186796544: Issue 1517 - Always call parseInt() with a radix as second argument

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: background.js

Issue 5171007186796544: Issue 1517 - Always call parseInt() with a radix as second argument (Closed)

Patch Set: Created Oct. 31, 2014, 2:52 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: background.js

===================================================================

--- a/background.js

+++ b/background.js

@@ -52,7 +52,7 @@

// https://code.google.com/p/chromium/issues/detail?id=291485

var canUseChromeNotifications = require("info").platform == "chromium"

&& "notifications" in chrome

- && (navigator.platform.indexOf("Linux") == -1 || parseInt(require("info").applicationVersion) > 34);

+ && (navigator.platform.indexOf("Linux") == -1 || parseInt(require("info").applicationVersion, 10) > 34);

var seenDataCorruption = false;

var filterlistsReinitialized = false;

« no previous file with comments | « no previous file | include.preload.js » ('j') | no next file with comments »