Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5198627827875840: Issue 424 - Anti-adblock filterlist disabled on extension update (Firefox) (Closed)

Created:
May 5, 2014, 2:30 p.m. by Thomas Greiner
Modified:
May 5, 2014, 4:11 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 424 - Anti-adblock filterlist disabled on extension update (Firefox)

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M lib/ui.js View 1 1 chunk +10 lines, -7 lines 1 comment Download

Messages

Total messages: 2
Thomas Greiner
May 5, 2014, 2:35 p.m. (2014-05-05 14:35:48 UTC) #1
Wladimir Palant
May 5, 2014, 3:20 p.m. (2014-05-05 15:20:54 UTC) #2
LGTM with the comment below addressed.

http://codereview.adblockplus.org/5198627827875840/diff/5685265389584384/lib/...
File lib/ui.js (right):

http://codereview.adblockplus.org/5198627827875840/diff/5685265389584384/lib/...
lib/ui.js:802: if (subscription)
This should be:

if (subscription && !(subscription.url in FilterStorage.knownSubscriptions))

This will make sure we will never override the settings for a subscription that
is always there.

Powered by Google App Engine
This is Rietveld