Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: installer/src/msi/adblockplusie.wxs

Issue 5219280069066752: Issue #1186 - Change names that appear in the custom action (Closed)
Left Patch Set: Created Oct. 2, 2014, 6:51 p.m.
Right Patch Set: Created Jan. 4, 2015, 7 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 <?xml version="1.0" encoding="UTF-8"?> 1 <?xml version="1.0" encoding="UTF-8"?>
2 <!-- 2 <!--
3 Compilation Note: 3 Compilation Note:
4 You may see linking errors that look like these: 4 You may see linking errors that look like these:
5 <quote>LGHT0217 : Error executing ICE action 'ICExx' [...] The error code is 2738.</quote> 5 <quote>LGHT0217 : Error executing ICE action 'ICExx' [...] The error code is 2738.</quote>
6 The documentation for this error code talks about custom actions, 6 The documentation for this error code talks about custom actions,
7 even though the CustomAction keyword does not appear in this source. 7 even though the CustomAction keyword does not appear in this source.
8 Certain WiX elements are implemented by MSI custom actions, 8 Certain WiX elements are implemented by MSI custom actions,
9 which means this source implicitly declares some insofar as the Windows Inst aller sees it. 9 which means this source implicitly declares some insofar as the Windows Inst aller sees it.
10 These errors are benign and can be avoided by some fiddling with the registry on the development machine. 10 These errors are benign and can be avoided by some fiddling with the registry on the development machine.
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 <?define build_dir="ia32"?> 53 <?define build_dir="ia32"?>
54 <?elseif $(sys.BUILDARCH)="x64"?> 54 <?elseif $(sys.BUILDARCH)="x64"?>
55 <?define Minimum_Version="200"?> 55 <?define Minimum_Version="200"?>
56 <?define Program_Files="ProgramFiles64Folder"?> 56 <?define Program_Files="ProgramFiles64Folder"?>
57 <?define Product_Name="!(loc.ProductName64)"?> 57 <?define Product_Name="!(loc.ProductName64)"?>
58 <?define build_dir="x64"?> 58 <?define build_dir="x64"?>
59 <?else?> 59 <?else?>
60 <?error Unsupported value of sys.BUILDARCH=$(sys.BUILDARCH)?> 60 <?error Unsupported value of sys.BUILDARCH=$(sys.BUILDARCH)?>
61 <?endif?> 61 <?endif?>
62 62
63 <?ifdef NoTransforms?>
64 <?define SupportedLanguages="9"?>
65 <?else?>
66 <?define SupportedLanguages="9,1,7,12,16,19,1026,1027,1029,1030,1032,1034,1035 ,1037,1038,1041,1044,1045,1046,1048,1049,1050,1051,1053,1054,1055,1058,1061,2052 ,2070"?>
67 <?endif?>
68
63 <!-- 69 <!--
64 The current directory when the compiler runs is "installer/build/<arch>". 70 The current directory when the compiler runs is "installer/build/<arch>".
65 Most assets are based in the root directory, three levels up. 71 Most assets are based in the root directory, three levels up.
66 The custom action library is base in the installer directory, two levels up. 72 The custom action library is base in the installer directory, two levels up.
67 --> 73 -->
68 <?define plugin_dir="..\..\.." ?> 74 <?define plugin_dir="..\..\.." ?>
69 <?define installer_dir="..\.." ?> 75 <?define installer_dir="..\.." ?>
70 76
71 <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi"> 77 <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">
72 <!-- 78 <!--
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 The build system presently embeds transforms for them, but without their L CID in this list, they won't be recognized. 111 The build system presently embeds transforms for them, but without their L CID in this list, they won't be recognized.
106 These embedded transforms, however, can be explicitly applied on the comma nd line of msiexec. 112 These embedded transforms, however, can be explicitly applied on the comma nd line of msiexec.
107 --> 113 -->
108 <Package 114 <Package
109 SummaryCodepage="1252" 115 SummaryCodepage="1252"
110 Keywords="Installer, Adblock Plus" 116 Keywords="Installer, Adblock Plus"
111 Description="Adblock Plus for IE" 117 Description="Adblock Plus for IE"
112 Comments="Thank you for using Adblock Plus." 118 Comments="Thank you for using Adblock Plus."
113 Manufacturer="Eyeo GmbH" 119 Manufacturer="Eyeo GmbH"
114 InstallerVersion="$(var.Minimum_Version)" 120 InstallerVersion="$(var.Minimum_Version)"
115 Languages="9,1,7,12,16,19,1026,1027,1029,1030,1032,1034,1035,1037,1038,104 1,1044,1045,1046,1048,1049,1050,1051,1053,1054,1055,1058,1061,2052,2070" 121 Languages="$(var.SupportedLanguages)"
116 Compressed="yes" 122 Compressed="yes"
117 InstallScope="perMachine" InstallPrivileges="elevated" 123 InstallScope="perMachine" InstallPrivileges="elevated"
118 /> 124 />
119 <!-- 125 <!--
120 The MajorUpgrade tag allows us to specify the relationship between our 126 The MajorUpgrade tag allows us to specify the relationship between our
121 version number and the one installed. The attribute Disallow="no" is 127 version number and the one installed. The attribute Disallow="no" is
122 implied and allows major upgrades to be performed. Downgrades aren't 128 implied and allows major upgrades to be performed. Downgrades aren't
123 allowed by default. 129 allowed by default.
124 130
125 The @Schedule attribute looks a little opaque. 131 The @Schedule attribute looks a little opaque.
126 Suffice it to say that it's the only option for scheduling where uninstall ation of the previous version 132 Suffice it to say that it's the only option for scheduling where uninstall ation of the previous version
127 and installation of the present version is _always_ going to act atomica lly. 133 and installation of the present version is _always_ going to act atomica lly.
128 It's a shame that you to even explicitly make that choice. 134 It's a shame that you to even explicitly make that choice.
129 --> 135 -->
130 <MajorUpgrade 136 <MajorUpgrade
131 Schedule="afterInstallExecute" 137 Schedule="afterInstallExecute"
132 DowngradeErrorMessage="!(loc.AlreadyInstalled)" 138 AllowDowngrades="yes"
133 /> 139 />
134 <MediaTemplate EmbedCab="yes"/> 140 <MediaTemplate EmbedCab="yes"/>
135 141
136 <!-- 142 <!--
137 User interface 143 User interface
138 --> 144 -->
139 <UIRef Id="custom_WixUI_InstallDir"/> 145 <UIRef Id="custom_WixUI_InstallDir"/>
140 <UIRef Id="WixUI_ErrorProgressText"/> 146 <UIRef Id="WixUI_ErrorProgressText"/>
141 <Property Id="WIXUI_INSTALLDIR" Value="INSTALLFOLDER"/> 147 <Property Id="WIXUI_INSTALLDIR" Value="INSTALLFOLDER"/>
142 148
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 <ComponentRef Id="html_static_img_background.png"/> 352 <ComponentRef Id="html_static_img_background.png"/>
347 <ComponentRef Id="html_static_img_bb_disable.png"/> 353 <ComponentRef Id="html_static_img_bb_disable.png"/>
348 <ComponentRef Id="html_static_img_bb_disable_active.png"/> 354 <ComponentRef Id="html_static_img_bb_disable_active.png"/>
349 <ComponentRef Id="html_static_img_bb_donate.png"/> 355 <ComponentRef Id="html_static_img_bb_donate.png"/>
350 <ComponentRef Id="html_static_img_bb_enable.png"/> 356 <ComponentRef Id="html_static_img_bb_enable.png"/>
351 <ComponentRef Id="html_static_img_bb_enable_active.png"/> 357 <ComponentRef Id="html_static_img_bb_enable_active.png"/>
352 <ComponentRef Id="html_static_img_checkmark.png"/> 358 <ComponentRef Id="html_static_img_checkmark.png"/>
353 <ComponentRef Id="html_static_img_features_language.png"/> 359 <ComponentRef Id="html_static_img_features_language.png"/>
354 <ComponentRef Id="html_static_img_features_adblocking.png"/> 360 <ComponentRef Id="html_static_img_features_adblocking.png"/>
355 <ComponentRef Id="html_static_img_social_facebook.png"/> 361 <ComponentRef Id="html_static_img_social_facebook.png"/>
356 <ComponentRef Id="html_static_img_social_facebook_old.png"/>
357 <ComponentRef Id="html_static_img_social_gplus.png"/> 362 <ComponentRef Id="html_static_img_social_gplus.png"/>
358 <ComponentRef Id="html_static_img_social_gplus_old.png"/>
359 <ComponentRef Id="html_static_img_social_twitter.png"/> 363 <ComponentRef Id="html_static_img_social_twitter.png"/>
360 <ComponentRef Id="html_static_img_social_twitter_old.png"/>
361 <ComponentRef Id="html_static_js_firstRun.js"/> 364 <ComponentRef Id="html_static_js_firstRun.js"/>
362 <ComponentRef Id="html_static_js_IESettings.js"/> 365 <ComponentRef Id="html_static_js_IESettings.js"/>
363 <ComponentRef Id="html_static_js_ieEventListenerPolyfill.js"/> 366 <ComponentRef Id="html_static_js_ieEventListenerPolyfill.js"/>
364 <ComponentRef Id="html_static_js_ieFirstRun.js"/> 367 <ComponentRef Id="html_static_js_ieFirstRun.js"/>
365 <ComponentRef Id="html_static_js_settings.js"/> 368 <ComponentRef Id="html_static_js_settings.js"/>
366 <ComponentRef Id="html_static_js_vendor_DD.belatedPNG.js"/> 369 <ComponentRef Id="html_static_js_vendor_DD.belatedPNG.js"/>
367 <ComponentRef Id="html_static_js_vendor_html5shiv.js"/> 370 <ComponentRef Id="html_static_js_vendor_html5shiv.js"/>
368 <ComponentRef Id="html_templates_firstRun.html"/> 371 <ComponentRef Id="html_templates_firstRun.html"/>
369 <ComponentRef Id="html_templates_index.html"/> 372 <ComponentRef Id="html_templates_index.html"/>
370 </ComponentGroup> 373 </ComponentGroup>
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
415 <File Name="language.png"/> 418 <File Name="language.png"/>
416 </Component> 419 </Component>
417 <Component Id="html_static_img_features_adblocking.png" Guid="7dd1 2150-d713-11e2-8b8b-0800200c9a66"> 420 <Component Id="html_static_img_features_adblocking.png" Guid="7dd1 2150-d713-11e2-8b8b-0800200c9a66">
418 <File Name="adblocking.png"/> 421 <File Name="adblocking.png"/>
419 </Component> 422 </Component>
420 </Directory> 423 </Directory>
421 <Directory Name="social" Id="html_static_img_social"> 424 <Directory Name="social" Id="html_static_img_social">
422 <Component Id="html_static_img_social_facebook.png" Guid="862e7c00 -d713-11e2-8b8b-0800200c9a66"> 425 <Component Id="html_static_img_social_facebook.png" Guid="862e7c00 -d713-11e2-8b8b-0800200c9a66">
423 <File Name="facebook.png"/> 426 <File Name="facebook.png"/>
424 </Component> 427 </Component>
425 <Component Id="html_static_img_social_facebook_old.png" Guid="2638 6980-f074-11e2-b778-0800200c9a66">
426 <File Name="facebook-old.png"/>
427 </Component>
428 <Component Id="html_static_img_social_gplus.png" Guid="8de48390-d7 13-11e2-8b8b-0800200c9a66"> 428 <Component Id="html_static_img_social_gplus.png" Guid="8de48390-d7 13-11e2-8b8b-0800200c9a66">
429 <File Name="gplus.png"/> 429 <File Name="gplus.png"/>
430 </Component> 430 </Component>
431 <Component Id="html_static_img_social_gplus_old.png" Guid="2c0035a 0-f074-11e2-b778-0800200c9a66">
432 <File Name="gplus-old.png"/>
433 </Component>
434 <Component Id="html_static_img_social_twitter.png" Guid="948152f0- d713-11e2-8b8b-0800200c9a66"> 431 <Component Id="html_static_img_social_twitter.png" Guid="948152f0- d713-11e2-8b8b-0800200c9a66">
435 <File Name="twitter.png"/> 432 <File Name="twitter.png"/>
436 </Component>
437 <Component Id="html_static_img_social_twitter_old.png" Guid="2c003 5a1-f074-11e2-b778-0800200c9a66">
438 <File Name="twitter-old.png"/>
439 </Component> 433 </Component>
440 </Directory> 434 </Directory>
441 </Directory> 435 </Directory>
442 <Directory Name="js" Id="html_static_js"> 436 <Directory Name="js" Id="html_static_js">
443 <Component Id="html_static_js_firstRun.js" Guid="2c0035a2-f074-11e2- b778-0800200c9a66"> 437 <Component Id="html_static_js_firstRun.js" Guid="2c0035a2-f074-11e2- b778-0800200c9a66">
444 <File Name="firstRun.js"/> 438 <File Name="firstRun.js"/>
445 </Component> 439 </Component>
446 <Component Id="html_static_js_ieFirstRun.js" Guid="f2a86685-d713-11e 2-8b8b-0800200c9a66"> 440 <Component Id="html_static_js_ieFirstRun.js" Guid="f2a86685-d713-11e 2-8b8b-0800200c9a66">
447 <File Name="ieFirstRun.js"/> 441 <File Name="ieFirstRun.js"/>
448 </Component> 442 </Component>
(...skipping 371 matching lines...) Expand 10 before | Expand all | Expand 10 after
820 <Component Id="ini_settings.ini" Guid="dc30c3b0-d713-11e2-8b8b-0800200c9 a66"> 814 <Component Id="ini_settings.ini" Guid="dc30c3b0-d713-11e2-8b8b-0800200c9 a66">
821 <File Name="settings.ini"/> 815 <File Name="settings.ini"/>
822 </Component> 816 </Component>
823 </Directory> 817 </Directory>
824 </DirectoryRef> 818 </DirectoryRef>
825 819
826 <?include ../installer-lib/custom-i18n.wxi ?> 820 <?include ../installer-lib/custom-i18n.wxi ?>
827 <?include ../custom-action/close_ie.wxi ?> 821 <?include ../custom-action/close_ie.wxi ?>
828 </Product> 822 </Product>
829 </Wix> 823 </Wix>
LEFTRIGHT

Powered by Google App Engine
This is Rietveld