Made the bubble use the ext object from the background page instead of including ext/background.js

The bubble (popup.html) had its own instance of ext (the abstraction layer). However this didn't only caused longer load time and larger memory footprint for the bubble, but also lead to issues on Safari.

The TabMap compares raw tab instances, however the same tab is represented by a different objects in the bubble and in the background page. But that might not be the only issue.

[Wladimir Palant, 2014-01-15 16:39:18]

LGTM with the nit addressed.

http://codereview.adblockplus.org/5220277533278208/diff/5629499534213120/chro...
File chrome/ext/popup.js (right):

http://codereview.adblockplus.org/5220277533278208/diff/5629499534213120/chro...
chrome/ext/popup.js:5: }
Please don't use the with statement, it is deprecated (see
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/...).
There is nothing wrong with assigning to a temp variable.

http://codereview.adblockplus.org/5220277533278208/diff/5629499534213120/safa...
File safari/ext/background.js (right):

http://codereview.adblockplus.org/5220277533278208/diff/5629499534213120/safa...
safari/ext/background.js:192: /* Background page proxy */
I am assuming that for the code below only the indentation changed. Let me know
if that's not the case.

[Sebastian Noack, 2014-01-15 16:55:20]

http://codereview.adblockplus.org/5220277533278208/diff/5629499534213120/chro...
File chrome/ext/popup.js (right):

http://codereview.adblockplus.org/5220277533278208/diff/5629499534213120/chro...
chrome/ext/popup.js:5: }
On 2014/01/15 16:39:19, Wladimir Palant wrote:
> Please don't use the with statement, it is deprecated (see
>
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/...).
> There is nothing wrong with assigning to a temp variable.

Done.

http://codereview.adblockplus.org/5220277533278208/diff/5629499534213120/safa...
File safari/ext/background.js (right):

http://codereview.adblockplus.org/5220277533278208/diff/5629499534213120/safa...
safari/ext/background.js:192: /* Background page proxy */
On 2014/01/15 16:39:19, Wladimir Palant wrote:
> I am assuming that for the code below only the indentation changed. Let me
know
> if that's not the case.

Yes, since the check above isn't needed anymore, I have changed the indentation
after removing the if-statement. Beside that there are no changes in that code.

[Wladimir Palant, 2014-01-16 07:46:42]

http://codereview.adblockplus.org/5220277533278208/diff/5657382461898752/chro...
File chrome/ext/popup.js (right):

http://codereview.adblockplus.org/5220277533278208/diff/5657382461898752/chro...
chrome/ext/popup.js:5: TabMap = backgroundPage.TabMap;
Assigning to undeclared variables isn't the fine art either. You need either
|var ext, TabMap| before this function or assign to window.ext and
window.TabMap.