Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/ext/popup.js

Issue 5220277533278208: Made the bubble use the ext object from the background page instead of including ext/background.js (Closed)
Patch Set: Created Dec. 21, 2013, 7:12 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | metadata.common » ('j') | safari/ext/background.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/ext/popup.js
===================================================================
new file mode 100644
--- /dev/null
+++ b/chrome/ext/popup.js
@@ -0,0 +1,5 @@
+with (chrome.extension.getBackgroundPage())
+{
+ this.ext = ext;
+ this.TabMap = TabMap;
+}
Wladimir Palant 2014/01/15 16:39:19 Please don't use the with statement, it is depreca
Sebastian Noack 2014/01/15 16:55:21 Done.
« no previous file with comments | « no previous file | metadata.common » ('j') | safari/ext/background.js » ('J')

Powered by Google App Engine
This is Rietveld