src/plugin/PluginDomTraverserBase.h - Issue 5242186790600704: Issue 1466 - Fix a typo in PluginDomTraverserBase.h

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/plugin/PluginDomTraverserBase.h

Issue 5242186790600704: Issue 1466 - Fix a typo in PluginDomTraverserBase.h (Closed)

Patch Set: Created Feb. 25, 2015, 6:34 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/plugin/PluginDomTraverserBase.h

===================================================================

--- a/src/plugin/PluginDomTraverserBase.h

+++ b/src/plugin/PluginDomTraverserBase.h

@@ -274,7 +274,7 @@

{

CComVariant vAttr;

- if (SUCCEEDED(pFrameEl->getAttribute(ATL::CComBSTR(L"scr"), 0, &vAttr)) && vAttr.vt == VT_BSTR && ::SysStringLen(vAttr.bstrVal) > 0)

Eric 2015/02/25 21:47:15 Good catch.

+ if (SUCCEEDED(pFrameEl->getAttribute(ATL::CComBSTR(L"src"), 0, &vAttr)) && vAttr.vt == VT_BSTR && ::SysStringLen(vAttr.bstrVal) > 0)

{

CString srcLegacy = vAttr.bstrVal;

« no previous file with comments | « no previous file | no next file » | no next file with comments »