Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5242593268989952: Issue 2340 - Don`t generate pages if less than 30% have been translated (Closed)

Created:
April 17, 2015, 5:19 p.m. by Wladimir Palant
Modified:
May 6, 2015, 7:20 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 2340 - Don`t generate pages if less than 30% have been translated

Patch Set 1 #

Total comments: 7

Patch Set 2 : Addressed comments #

Patch Set 3 : Don`t link to pages that don`t exist #

Total comments: 12

Patch Set 4 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -23 lines) Patch
M cms/bin/generate_static_pages.py View 1 2 3 2 chunks +39 lines, -8 lines 0 comments Download
M cms/converters.py View 1 2 3 3 chunks +12 lines, -2 lines 0 comments Download
M cms/sources.py View 1 2 2 chunks +5 lines, -10 lines 0 comments Download
M cms/utils.py View 1 2 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 11
Wladimir Palant
April 17, 2015, 5:19 p.m. (2015-04-17 17:19:34 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5242593268989952/diff/5629499534213120/cms/utils.py File cms/utils.py (right): http://codereview.adblockplus.org/5242593268989952/diff/5629499534213120/cms/utils.py#newcode63 cms/utils.py:63: for l in source.list_locales() Parameter being overwritten here isn't ...
April 17, 2015, 5:22 p.m. (2015-04-17 17:22:31 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5242593268989952/diff/5629499534213120/cms/bin/generate_static_pages.py File cms/bin/generate_static_pages.py (right): http://codereview.adblockplus.org/5242593268989952/diff/5629499534213120/cms/bin/generate_static_pages.py#newcode22 cms/bin/generate_static_pages.py:22: MIN_TRANSLATED = 0.3 Is this actually the same threshold ...
April 17, 2015, 5:32 p.m. (2015-04-17 17:32:27 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/5242593268989952/diff/5629499534213120/cms/bin/generate_static_pages.py File cms/bin/generate_static_pages.py (right): http://codereview.adblockplus.org/5242593268989952/diff/5629499534213120/cms/bin/generate_static_pages.py#newcode22 cms/bin/generate_static_pages.py:22: MIN_TRANSLATED = 0.3 On 2015/04/17 17:32:27, Sebastian Noack wrote: ...
April 17, 2015, 6:21 p.m. (2015-04-17 18:21:15 UTC) #4
Sebastian Noack
LGTM
April 18, 2015, 8:04 a.m. (2015-04-18 08:04:34 UTC) #5
Wladimir Palant
On 2015/04/18 08:04:34, Sebastian Noack wrote: > LGTM Not quite unfortunately. I realized that this ...
April 18, 2015, 8:56 a.m. (2015-04-18 08:56:50 UTC) #6
Wladimir Palant
I've changed the approach here and rebased, links to non-existing pages shouldn't be generated any ...
May 6, 2015, 3:20 p.m. (2015-05-06 15:20:52 UTC) #7
Sebastian Noack
I'm not quite sure whether it's a great idea to have inconsistent behavior when generating ...
May 6, 2015, 4:15 p.m. (2015-05-06 16:15:30 UTC) #8
Wladimir Palant
On 2015/05/06 16:15:30, Sebastian Noack wrote: > I'm not quite sure whether it's a great ...
May 6, 2015, 5:21 p.m. (2015-05-06 17:21:59 UTC) #9
Sebastian Noack
On 2015/05/06 17:21:59, Wladimir Palant wrote: > The development server should by definition show all ...
May 6, 2015, 7:12 p.m. (2015-05-06 19:12:15 UTC) #10
Wladimir Palant
May 6, 2015, 7:20 p.m. (2015-05-06 19:20:35 UTC) #11
http://codereview.adblockplus.org/5242593268989952/diff/5733935958982656/cms/...
File cms/bin/generate_static_pages.py (right):

http://codereview.adblockplus.org/5242593268989952/diff/5733935958982656/cms/...
cms/bin/generate_static_pages.py:39: wrapper.original = func
On 2015/05/06 19:12:15, Sebastian Noack wrote:
> However, I'm not feeling too strong about it. So LGTM if you disagree.

Thank you. Indeed, I do feel that the current approach is better than just
manipulating the dictionary used by memoize() and potentially breaking
assumptions that this decorator makes.

Powered by Google App Engine
This is Rietveld