Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5246523029848064: Issue 2212 - Implement http://subscribe.adblockplus.org/?... subscription links (Closed)

Created:
March 25, 2015, 2:01 p.m. by Sebastian Noack
Modified:
March 25, 2015, 3:34 p.m.
Visibility:
Public.

Description

Issue 2212 - Implement http://subscribe.adblockplus.org/?... subscription links

Patch Set 1 #

Total comments: 7

Patch Set 2 : Removed unneeded regexp group #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M include.postload.js View 1 1 chunk +13 lines, -7 lines 0 comments Download

Messages

Total messages: 7
Sebastian Noack
March 25, 2015, 2:03 p.m. (2015-03-25 14:03:00 UTC) #1
kzar
LGTM http://codereview.adblockplus.org/5246523029848064/diff/5629499534213120/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/5246523029848064/diff/5629499534213120/include.postload.js#newcode621 include.postload.js:621: if (link.protocol == "http:" || link.protocol == "https:") ...
March 25, 2015, 2:09 p.m. (2015-03-25 14:09:29 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5246523029848064/diff/5629499534213120/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/5246523029848064/diff/5629499534213120/include.postload.js#newcode621 include.postload.js:621: if (link.protocol == "http:" || link.protocol == "https:") On ...
March 25, 2015, 2:21 p.m. (2015-03-25 14:21:03 UTC) #3
Thomas Greiner
http://codereview.adblockplus.org/5246523029848064/diff/5629499534213120/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/5246523029848064/diff/5629499534213120/include.postload.js#newcode626 include.postload.js:626: else if (!/^abp:\/*subscribe\/*\?(.*)/i.test(link.href)) The `(.*)` at the end of ...
March 25, 2015, 3:05 p.m. (2015-03-25 15:05:36 UTC) #4
Wladimir Palant
http://codereview.adblockplus.org/5246523029848064/diff/5629499534213120/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/5246523029848064/diff/5629499534213120/include.postload.js#newcode626 include.postload.js:626: else if (!/^abp:\/*subscribe\/*\?(.*)/i.test(link.href)) Nit: Please remove the parentheses in ...
March 25, 2015, 3:07 p.m. (2015-03-25 15:07:16 UTC) #5
Sebastian Noack
http://codereview.adblockplus.org/5246523029848064/diff/5629499534213120/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/5246523029848064/diff/5629499534213120/include.postload.js#newcode626 include.postload.js:626: else if (!/^abp:\/*subscribe\/*\?(.*)/i.test(link.href)) On 2015/03/25 15:05:36, Thomas Greiner wrote: ...
March 25, 2015, 3:23 p.m. (2015-03-25 15:23:26 UTC) #6
Wladimir Palant
March 25, 2015, 3:29 p.m. (2015-03-25 15:29:21 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld