Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5276432552951808: Some fixes related to the new Australis Firefox theme (Closed)

Created:
Nov. 20, 2013, 11:26 a.m. by Wladimir Palant
Modified:
Nov. 20, 2013, 2:42 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

This only fixes some of the issues. (1) Contribute button height is huge, being stretched by the hide button. (2) Button styling doesn't match the style of other buttons in the tool panel. (3) Clicking contribute button so its hide button closes tool panel but leaves our menu hanging all by itself. Remaining issues: * Restoring icon position is broken * Icon menu isn't being initialized when the icon is placed inside tool menu * Wrong icon color scheme when placed inside tool panel

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M chrome/content/ui/overlay.xul View 1 chunk +1 line, -1 line 0 comments Download
M chrome/skin/overlay.css View 2 chunks +5 lines, -1 line 3 comments Download
M lib/ui.js View 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Nov. 20, 2013, 11:26 a.m. (2013-11-20 11:26:19 UTC) #1
Felix Dahlke
I'd like to see a comment about that weird part below, otherwise LGTM. http://codereview.adblockplus.org/5276432552951808/diff/5629499534213120/chrome/skin/overlay.css File ...
Nov. 20, 2013, 2:15 p.m. (2013-11-20 14:15:54 UTC) #2
Wladimir Palant
Pushed with a comment added: https://hg.adblockplus.org/adblockplus/rev/e4bbaf48f134 http://codereview.adblockplus.org/5276432552951808/diff/5629499534213120/chrome/skin/overlay.css File chrome/skin/overlay.css (right): http://codereview.adblockplus.org/5276432552951808/diff/5629499534213120/chrome/skin/overlay.css#newcode172 chrome/skin/overlay.css:172: min-width: 0px !important; ...
Nov. 20, 2013, 2:36 p.m. (2013-11-20 14:36:32 UTC) #3
Felix Dahlke
Nov. 20, 2013, 2:42 p.m. (2013-11-20 14:42:57 UTC) #4
http://codereview.adblockplus.org/5276432552951808/diff/5629499534213120/chro...
File chrome/skin/overlay.css (right):

http://codereview.adblockplus.org/5276432552951808/diff/5629499534213120/chro...
chrome/skin/overlay.css:172: min-width: 0px !important;
On 2013/11/20 14:36:33, Wladimir Palant wrote:
> On 2013/11/20 14:15:55, Felix H. Dahlke wrote:
> > This seems pretty peculiar, worth a comment IMO.
> 
> Nothing special actually, the Australis theme defines some size properties for
> <toolbarbutton> widgets that stretch everything here unless overwritten.

I meant a comment in the source, to be clear :) But I'll leave that up to you,
it's not as peculiar as I first thought.

Powered by Google App Engine
This is Rietveld