issue 1435 - Port popup.html from Chrome/Safari/Opera to Firefox

chrome/content/ui/overlay.xul

 <?xml version="1.0"?>
 
 <!--
   - This file is part of Adblock Plus <http://adblockplus.org/>,
   - Copyright (C) 2006-2014 Eyeo GmbH
   -
   - Adblock Plus is free software: you can redistribute it and/or modify
   - it under the terms of the GNU General Public License version 3 as
   - published by the Free Software Foundation.
   -
@@ skipping 28 matching lines @@
       <description id="abp-tooltip-status"/>
       <label id="abp-tooltip-blocked-label" value="&blocked.tooltip;" hidden="true"/>
       <description id="abp-tooltip-blocked" hidden="true"/>
       <label id="abp-tooltip-filters-label" value="&filters.tooltip;" hidden="true"/>
       <vbox id="abp-tooltip-filters" hidden="true"/>
       <description id="abp-tooltip-more-filters" value="…" hidden="true"/>
     </tooltip>
   </popupset>
 
   <!-- Icon's context menu -->
-  <menupopup id="abp-status-popup" context="">
-    <menuitem id="abp-status-sendReport" label="&sendReport.label;…" key="abp-key-sendReport" command="abp-command-sendReport"/>
-    <menuitem id="abp-status-openbottombar" label="&opensidebar.label;" key="abp-key-sidebar" command="abp-command-sidebar"/>
-    <menuitem id="abp-status-closebottombar" label="&closesidebar.label;" key="abp-key-sidebar" command="abp-command-sidebar"/>
-    <menuitem id="abp-status-filters" label="&filters.label;…" key="abp-key-filters" command="abp-command-filters"/>
-    <menuseparator id="abp-status-whitelist-sep"/>
-    <menuitem id="abp-status-whitelistsite" labeltempl="&whitelist.site.label;" type="checkbox" command="abp-command-togglesitewhitelist"/>
-    <menuitem id="abp-status-whitelistpage" label="&whitelist.page.label;" type="checkbox" command="abp-command-togglepagewhitelist"/>
-    <menuitem id="abp-status-disabled" label="&disable.label;" type="checkbox" key="abp-key-enable" command="abp-command-enable"/>
-    <menuseparator/>
-    <menu id="abp-status-options" label="&options.label;">
-      <menupopup id="abp-status-options-popup">
-        <menuitem id="abp-status-frameobjects" label="&objecttabs.label;" type="checkbox" command="abp-command-toggleobjtabs"/>
-        <menuitem id="abp-status-slowcollapse" label="&hideplaceholders.label;" type="checkbox" command="abp-command-togglecollapse"/>
-        <menuitem id="abp-status-savestats" label="&counthits.label;" type="checkbox" command="abp-command-togglesavestats"/>
-        <menuitem id="abp-status-sync" label="&sync.label;" type="checkbox" command="abp-command-togglesync"/>
-        <menuseparator id="abp-status-iconSettingsSeparator"/>
-        <menuitem id="abp-status-showintoolbar" label="&showintoolbar.label;" type="checkbox" command="abp-command-toggleshowintoolbar"/>
-        <menuitem id="abp-status-showinstatusbar" label="&showinstatusbar.label;" type="checkbox" command="abp-command-toggleshowinstatusbar"/>
-      </menupopup>
-    </menu>
+  <panel id="abp-status-popup" type="arrow">
+    <iframe id="abp-status-popup-browser" src="about:blank" flex="1"/>
+  </panel>
+  
+  <menu id="abp-menuitem" label="&toolbarbutton.label;">

[Thomas Greiner, 2014/10/17 15:02:21]

You removed the comment "Tools menu". Please add it back above here.

[saroyanm, 2014/10/21 13:39:21]

Done.

+    <menupopup id="abp-menuitem-popup" context="">
+      <menuitem id="abp-menuitem-sendReport" label="&sendReport.label;…" key="abp-key-sendReport" command="abp-command-sendReport"/>
+      <menuitem id="abp-menuitem-openbottombar" label="&opensidebar.label;" key="abp-key-sidebar" command="abp-command-sidebar"/>
+      <menuitem id="abp-menuitem-closebottombar" label="&closesidebar.label;" key="abp-key-sidebar" command="abp-command-sidebar"/>
+      <menuitem id="abp-menuitem-filters" label="&filters.label;…" key="abp-key-filters" command="abp-command-filters"/>
+      <menuseparator id="abp-menuitem-whitelist-sep"/>
+      <menuitem id="abp-menuitem-whitelistsite" labeltempl="&whitelist.site.label;" type="checkbox" command="abp-command-togglesitewhitelist"/>
+      <menuitem id="abp-menuitem-whitelistpage" label="&whitelist.page.label;" type="checkbox" command="abp-command-togglepagewhitelist"/>
+      <menuitem id="abp-menuitem-disabled" label="&disable.label;" type="checkbox" key="abp-key-enable" command="abp-command-enable"/>
+      <menuseparator/>
+      <menu id="abp-menuitem-options" label="&options.label;">
+        <menupopup id="abp-menuitem-options-popup">
+          <menuitem id="abp-menuitem-frameobjects" label="&objecttabs.label;" type="checkbox" command="abp-command-toggleobjtabs"/>
+          <menuitem id="abp-menuitem-slowcollapse" label="&hideplaceholders.label;" type="checkbox" command="abp-command-togglecollapse"/>
+          <menuitem id="abp-menuitem-savestats" label="&counthits.label;" type="checkbox" command="abp-command-togglesavestats"/>
+          <menuitem id="abp-menuitem-sync" label="&sync.label;" type="checkbox" command="abp-command-togglesync"/>
+          <menuseparator id="abp-menuitem-iconSettingsSeparator"/>
+          <menuitem id="abp-menuitem-showintoolbar" label="&showintoolbar.label;" type="checkbox" command="abp-command-toggleshowintoolbar"/>
+          <menuitem id="abp-menuitem-showinstatusbar" label="&showinstatusbar.label;" type="checkbox" command="abp-command-toggleshowinstatusbar"/>
+        </menupopup>
+      </menu>
 
-    <hbox class="abp-contributebutton" id="abp-status-contributebutton" pack="center" align="center">
-      <!-- noautoclose attribute tells Australis menu that it shouldn't close when
-           these are clicked, see https://bugzilla.mozilla.org/show_bug.cgi?id=940693 -->
-      <button class="abp-contributebutton-btn" label="&contribute.label;" command="abp-command-contribute" flex="1" noautoclose="true"/>
-      <toolbarbutton class="abp-contributebutton-close" command="abp-command-contribute-hide" noautoclose="true"/>
-    </hbox>
-  </menupopup>
-
+      <hbox class="abp-contributebutton" id="abp-status-contributebutton" pack="center" align="center">
+        <!-- noautoclose attribute tells Australis menu that it shouldn't close when
+             these are clicked, see https://bugzilla.mozilla.org/show_bug.cgi?id=940693 -->
+        <button class="abp-contributebutton-btn" label="&contribute.label;" command="abp-command-contribute" flex="1" noautoclose="true"/>
+        <toolbarbutton class="abp-contributebutton-close" command="abp-command-contribute-hide" noautoclose="true"/>
+      </hbox>
+    </menupopup>
+  </menu>
   <keyset id="abp-keyset"/>
 
   <!-- Dummy oncommand attributes are work-arounds for bug 371900 -->
   <commandset id="abp-commandset">
     <command id="abp-command-sendReport" oncommand="//"/>
     <command id="abp-command-filters" oncommand="//"/>
     <command id="abp-command-settings" oncommand="//"/>
     <command id="abp-command-sidebar" oncommand="//"/>
     <command id="abp-command-togglesitewhitelist"/>
     <command id="abp-command-togglepagewhitelist"/>
     <command id="abp-command-toggleobjtabs"/>
     <command id="abp-command-togglecollapse"/>
     <command id="abp-command-togglesavestats"/>
     <command id="abp-command-togglesync"/>
     <command id="abp-command-toggleshowintoolbar"/>
     <command id="abp-command-toggleshowinstatusbar"/>
     <command id="abp-command-enable" oncommand="//"/>
     <command id="abp-command-contribute"/>
     <command id="abp-command-contribute-hide"/>
   </commandset>
 
   <statusbarpanel id="abp-status" class="statusbarpanel-iconic"
       tooltip="abp-tooltip"/>
 
   <toolbarbutton id="abp-toolbarbutton" class="toolbarbutton-1" label="&toolbarbutton.label;"
       tooltip="abp-tooltip"/>
 
-  <!-- Tools menu -->
-  <menu id="abp-menuitem" label="&toolbarbutton.label;"/>
-
   <!-- Bottom bar -->
   <hbox id="abp-bottombar-container">
     <splitter id="abp-bottombar-splitter"/>
     <vbox id="abp-bottombar">
       <toolbox id="abp-bottombar-header">
         <toolbar id="abp-bottombar-toolbar" align="center" grippyhidden="true" fullscreentoolbar="true">
           <label id="abp-bottombar-title" control="abp-bottombar-browser" value="&sidebar.title;" flex="1" crop="end"/>
           <toolbarbutton id="abp-bottombar-close" command="abp-command-sidebar" tooltiptext="&closesidebar.label;"/>
         </toolbar>
       </toolbox>
       <iframe id="abp-bottombar-browser" src="chrome://adblockplus/content/ui/sidebar.xul" flex="1"/>
     </vbox>
   </hbox>
 
   <!-- Notification panel -->
   <panel id="abp-notification" type="arrow" orient="vertical"
     xmlns:html="http://www.w3.org/1999/xhtml">
     <label id="abp-notification-title" class="header"/>
     <html:p id="abp-notification-message"/>
     <hbox id="abp-notification-question">
       <button id="abp-notification-yes" label="&notification.button.yes;"/>
       <button id="abp-notification-no" label="&notification.button.no;"/>
       <toolbarbutton id="abp-notification-close" label="&notification.button.close;"></toolbarbutton>
     </hbox>
   </panel>
 </overlay>