Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: chrome/skin/popup.css

Issue 5294633391226880: issue 1435 - Port popup.html from Chrome/Safari/Opera to Firefox (Closed)
Left Patch Set: Created Oct. 16, 2014, 11:07 a.m.
Right Patch Set: Created Oct. 27, 2014, 9:40 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 #clickhide-instructions 157 #clickhide-instructions
158 { 158 {
159 margin: 10px 15px; 159 margin: 10px 15px;
160 } 160 }
161 161
162 #blockable .icon 162 #blockable .icon
163 { 163 {
164 background-position: -66px -17px; 164 background-position: -66px -17px;
165 } 165 }
166 166
167 #blockable .i18n_close_blockable_items, 167 #blockable:not(.open) [data-action="close"],
saroyanm 2014/10/16 11:26:15 What you think, can we use i18n related class name
Thomas Greiner 2014/10/16 13:39:44 Good point, let's better keep them separated. One
saroyanm 2014/10/17 11:42:15 good point.
168 #blockable.open .i18n_blockable_items 168 #blockable.open [data-action="open"]
Thomas Greiner 2014/10/16 13:39:44 By using the :not() pseudo-class you could merge t
saroyanm 2014/10/17 11:42:15 Should have implemented, great!
169 { 169 {
170 display: none; 170 display: none;
171 }
172
173 #blockable.open .i18n_close_blockable_items
174 {
175 display: inline;
176 } 171 }
177 172
178 #report-issue .icon 173 #report-issue .icon
179 { 174 {
180 background-position: -50px -81px; 175 background-position: -50px -81px;
181 } 176 }
182 177
183 label 178 label
184 { 179 {
185 vertical-align: middle; 180 vertical-align: middle;
186 } 181 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld