issue 1435 - Port popup.html from Chrome/Safari/Opera to Firefox

chrome/content/ui/ext/popup.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 (function()
 {
   var {UI} = require("ui");
   
   var iframe = window.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
     .getInterface(Components.interfaces.nsIWebNavigation)
     .QueryInterface(Components.interfaces.nsIDocShell)
     .chromeEventHandler;

[Wladimir Palant, 2014/10/23 21:57:40]

Nice trick, wasn't aware of that.

   var topWindow = iframe.ownerDocument.defaultView;

[Wladimir Palant, 2014/10/23 21:57:40]

Please add a variable |panel = iframe.parentNode| - currently it's unclear what
this refers to.

[saroyanm, 2014/10/27 21:49:20]

Done.

-  
+  var panel = iframe.parentNode;
+
   // Firefox doesn't adjust the size of the popup automatically to the size
   // of its content, like when the ad counter is expanded/collapsed. So we use 
   // MutationObserver to do so.
   var resizingScheduled = false;
 
   function updateSize()
   {
     if (!resizingScheduled)
     {
       setTimeout(function()
       {
+        resizingScheduled = false;
+
         // We need to calculate the height difference because the panel's size includes 
         // the height of the arrow image and the border width of the panel content
-        var heightDifference = iframe.parentNode.clientHeight - iframe.clientHeight;
-        iframe.parentNode.sizeTo(document.body.scrollWidth, document.body.scrollHeight + heightDifference);
-        resizingScheduled = false;

[Wladimir Palant, 2014/10/23 21:57:40]

Please move that line to the top of the function - if any other code in this
function throws an exception we shouldn't end up in an invalid state.

[saroyanm, 2014/10/27 21:49:20]

Done.

+        var heightDifference = panel.clientHeight - iframe.clientHeight;
+        panel.sizeTo(document.body.scrollWidth, document.body.scrollHeight + heightDifference);
       }, 0);
 
       resizingScheduled = true;
     }
   }
 
   window.addEventListener("load", function()
   {
     updateSize();
     new MutationObserver(updateSize).observe(document, {
       childList: true, attributes: true,
       characterData: true, subtree: true
     });
   });
 
   ext = {

[Wladimir Palant, 2014/10/23 21:57:40]

Again, please don't assign to undeclared variables.

[saroyanm, 2014/10/27 21:49:20]

the ext from common.js should be accessible here I guess, I've declared ext in
utils.js and left a comment there.

     __proto__: ext,
     closePopup: function()
     {
-      iframe.parentNode.hidePopup();
+      panel.hidePopup();
     },
     openBlockable: function()
     {
       UI.toggleBottombar(topWindow);
       ext.closePopup();
     },
     isBlockableOpen: function()
     {
       return UI.isBottombarOpen(topWindow);
     },
     reportIssue: function()
     {
       UI.openReportDialog(topWindow);
     },
     showReportIssue: function()
     {
       var location = UI.getCurrentLocation(topWindow);
       return location && Policy.isBlockableScheme(location) && location.scheme != "mailto";
     }
   };
 })();