issue 1435 - Port popup.html from Chrome/Safari/Opera to Firefox

chrome/content/ui/popup.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 var backgroundPage = ext.backgroundPage.getWindow();
-window["openOptions"] = backgroundPage["openOptions"];

[Thomas Greiner, 2014/10/17 15:02:21]

I guess this is a leftover from the loop that was here before. Wouldn't you
rather write this?

var openOptions = backgroundPage.openOptions;

[saroyanm, 2014/10/21 13:39:21]

Done.

+var openOptions = backgroundPage.openOptions;
 var page = null;
 
 function init()
 {
   ext.pages.query({active: true, lastFocusedWindow: true}, function(pages)
   {
     page = pages[0];
     if (page)
     {
       document.body.classList.toggle("local", !/^https?:\/\//.test(page.url));
@@ skipping 71 matching lines @@
 function cancelClickHide()
 {
   if (activateClickHide.timeout)
   {
     window.clearTimeout(activateClickHide.timeout);
     activateClickHide.timeout = null;
   }
   document.body.classList.remove("clickhide-active");
   ext.activateClickHide(false);
 }