Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: chrome/content/ui/ext/popup.js

Issue 5294633391226880: issue 1435 - Port popup.html from Chrome/Safari/Opera to Firefox (Closed)
Left Patch Set: Created Oct. 10, 2014, 11:36 a.m.
Right Patch Set: Created Oct. 27, 2014, 9:40 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 (function() 18 (function()
19 { 19 {
20 var {UI} = require("ui"); 20 var {UI} = require("ui");
21 21
22 var iframe = window.QueryInterface(Components.interfaces.nsIInterfaceRequestor ) 22 var iframe = window.QueryInterface(Components.interfaces.nsIInterfaceRequestor )
23 .getInterface(Components.interfaces.nsIWebNavigation) 23 .getInterface(Components.interfaces.nsIWebNavigation)
24 .QueryInterface(Components.interfaces.nsIDocShell) 24 .QueryInterface(Components.interfaces.nsIDocShell)
25 .chromeEventHandler; 25 .chromeEventHandler;
26 var topWindow = iframe.ownerDocument.defaultView; 26 var topWindow = iframe.ownerDocument.defaultView;
27 27 var panel = iframe.parentNode;
28
28 // Firefox doesn't adjust the size of the popup automatically to the size 29 // Firefox doesn't adjust the size of the popup automatically to the size
29 // of its content, like when the ad counter is expanded/collapsed. So we use 30 // of its content, like when the ad counter is expanded/collapsed. So we use
30 // MutationObserver to do so. 31 // MutationObserver to do so.
31 var resizingScheduled = false; 32 var resizingScheduled = false;
32 33
33 function updateSize() 34 function updateSize()
34 { 35 {
35 if (!resizingScheduled) 36 if (!resizingScheduled)
36 { 37 {
37 setTimeout(function() 38 setTimeout(function()
38 { 39 {
39 // We need to calculate height difference while panel include
Thomas Greiner 2014/10/13 13:18:24 What do you mean with "while panel include"? Pleas
saroyanm 2014/10/16 11:26:15 Done.
40 // height of arrow image and border of the panel content
41 var heightDifference = iframe.parentNode.clientHeight - iframe.clientHei ght;
42 iframe.parentNode.sizeTo(document.body.scrollWidth, document.body.scroll Height + heightDifference);
43 resizingScheduled = false; 40 resizingScheduled = false;
41
42 // We need to calculate the height difference because the panel's size i ncludes
43 // the height of the arrow image and the border width of the panel conte nt
44 var heightDifference = panel.clientHeight - iframe.clientHeight;
45 panel.sizeTo(document.body.scrollWidth, document.body.scrollHeight + hei ghtDifference);
44 }, 0); 46 }, 0);
45 47
46 resizingScheduled = true; 48 resizingScheduled = true;
47 } 49 }
48 } 50 }
49 51
50 window.addEventListener("load", function() 52 window.addEventListener("load", function()
51 { 53 {
52 updateSize(); 54 updateSize();
53 new MutationObserver(updateSize).observe(document, { 55 new MutationObserver(updateSize).observe(document, {
54 childList: true, attributes: true, 56 childList: true, attributes: true,
55 characterData: true, subtree: true 57 characterData: true, subtree: true
56 }); 58 });
57 }); 59 });
58 60
59 ext = { 61 ext = {
60 __proto__: ext, 62 __proto__: ext,
61 closePopup: function() 63 closePopup: function()
62 { 64 {
63 iframe.parentNode.hidePopup(); 65 panel.hidePopup();
64 }, 66 },
65 openBlockable: function() 67 openBlockable: function()
66 { 68 {
67 UI.toggleBottombar(topWindow); 69 UI.toggleBottombar(topWindow);
68 ext.closePopup(); 70 ext.closePopup();
69 }, 71 },
70 isBlockableOpen: function() 72 isBlockableOpen: function()
71 { 73 {
72 return UI.isBottombarOpen(topWindow); 74 return UI.isBottombarOpen(topWindow);
73 }, 75 },
74 reportIssue: function() 76 reportIssue: function()
75 { 77 {
76 UI.openReportDialog(topWindow); 78 UI.openReportDialog(topWindow);
77 }, 79 },
78 showReportIssue: function() 80 showReportIssue: function()
79 { 81 {
80 var location = UI.getCurrentLocation(topWindow); 82 var location = UI.getCurrentLocation(topWindow);
81 return location && Policy.isBlockableScheme(location) && location.scheme ! = "mailto"; 83 return location && Policy.isBlockableScheme(location) && location.scheme ! = "mailto";
82 } 84 }
83 }; 85 };
84 })(); 86 })();
LEFTRIGHT

Powered by Google App Engine
This is Rietveld