src/shared/ContentType.h - Issue 5316782940225536: Issue 1557 - Update to the recent libadblockplus to reduce additional updates in the logic later.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: src/shared/ContentType.h

Issue 5316782940225536: Issue 1557 - Update to the recent libadblockplus to reduce additional updates in the logic later. (Closed)

Patch Set: remove debugging code Created Nov. 24, 2014, 11:09 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 #pragma once

	2 #include <AdblockPlus/FilterEngine.h>

	3

	4 std::string ContentTypeToString(AdblockPlus::FilterEngine::ContentType contentTy pe);
	Eric 2014/12/30 16:56:08 This function is only used for debugging, and thus This function is only used for debugging, and thus it could be declared within an #ifdef block. sergei 2015/01/13 13:13:14 I'm not sure that it makes sense because linker re Show quoted text On 2014/12/30 16:56:08, Eric wrote: > This function is only used for debugging, and thus it could be declared within > an #ifdef block. I'm not sure that it makes sense because linker removes unused code anyway (JIC, I've checked the sizes of addon DLL and engine exe in Release, they don't depend whether there are ContentType.{h,cpp} files or not). Without #ifdef it looks cleaner, doesn't?
OLD	NEW