Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/AdblockPlusClient.cpp

Issue 5316782940225536: Issue 1557 - Update to the recent libadblockplus to reduce additional updates in the logic later. (Closed)
Patch Set: link addon with libadblockplus Created Jan. 29, 2015, 4:05 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/plugin/AdblockPlusClient.cpp
diff --git a/src/plugin/AdblockPlusClient.cpp b/src/plugin/AdblockPlusClient.cpp
index ee6f86891e859f4b8a75d0b35743627ce8ea1111..08bb16bd96b3d0db9159ffe02e1b792d728d4ba6 100644
--- a/src/plugin/AdblockPlusClient.cpp
+++ b/src/plugin/AdblockPlusClient.cpp
@@ -225,7 +225,7 @@ CAdblockPlusClient* CAdblockPlusClient::GetInstance()
return instance;
}
-bool CAdblockPlusClient::ShouldBlock(const std::wstring& src, int contentType, const std::wstring& domain, bool addDebug)
+bool CAdblockPlusClient::ShouldBlock(const std::wstring& src, AdblockPlus::FilterEngine::ContentType contentType, const std::wstring& domain, bool addDebug)
{
bool isBlocked = false;
bool isCached = false;
@@ -250,7 +250,7 @@ bool CAdblockPlusClient::ShouldBlock(const std::wstring& src, int contentType, c
m_criticalSectionFilter.Unlock();
// Cache result, if content type is defined
- if (contentType != CFilter::contentTypeAny)
+ if (contentType != AdblockPlus::FilterEngine::ContentType::CONTENT_TYPE_OTHER)
{
m_criticalSectionCache.Lock();
{
@@ -304,10 +304,10 @@ bool CAdblockPlusClient::IsElemhideWhitelistedOnDomain(const std::wstring& url)
return isWhitelisted;
}
-bool CAdblockPlusClient::Matches(const std::wstring& url, const std::wstring& contentType, const std::wstring& domain)
+bool CAdblockPlusClient::Matches(const std::wstring& url, AdblockPlus::FilterEngine::ContentType contentType, const std::wstring& domain)
{
Communication::OutputBuffer request;
- request << Communication::PROC_MATCHES << ToUtf8String(url) << ToUtf8String(contentType) << ToUtf8String(domain);
+ request << Communication::PROC_MATCHES << ToUtf8String(url) << contentType << ToUtf8String(domain);
Communication::InputBuffer response;
if (!CallEngine(request, response))

Powered by Google App Engine
This is Rietveld