Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: common.gypi

Issue 5326829724368896: 1521 - libadblockplus is not compilable on linux x64 (Closed)
Left Patch Set: '1521 - libadblockplus is not compilable on linux x64' Created Jan. 14, 2015, 3:14 p.m.
Right Patch Set: 1521 - libadblockplus is not compilable on linux x64 Created Feb. 4, 2015, 10:19 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 { 1 {
2 'variables': { 2 'variables': {
3 'visibility%': 'hidden', 3 'visibility%': 'hidden',
4 'library%': 'static_library', 4 'library%': 'static_library',
5 'component%': '', 5 'component%': '',
6 'want_separate_host_toolset': 0, 6 'want_separate_host_toolset': 0,
7 'v8_optimized_debug': 0, 7 'v8_optimized_debug': 0,
8 'v8_enable_i18n_support': 0, 8 'v8_enable_i18n_support': 0,
9 }, 9 },
10 10
11 'conditions': [ 11 'conditions': [
12 ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \ 12 ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \
13 or OS=="netbsd" or OS=="android"', { 13 or OS=="netbsd" or OS=="android"', {
14 'target_defaults': { 14 'target_defaults': {
15 'cflags': [ '-Wall', '-pthread', '-fno-rtti', '-pedantic', 15 'cflags': [ '-Wall', '-W', '-Wno-unused-parameter',
16 » '-std=c++0x', '-fexceptions', ], 16 '-Wnon-virtual-dtor', '-pthread', '-fno-rtti',
sergei 2015/01/22 14:14:14 previously there were spaces.
17 '-pedantic', '-std=c++0x', '-fexceptions', ],
18 'cflags!': [ '-Werror', ],
17 'ldflags': [ '-pthread', ], 19 'ldflags': [ '-pthread', ],
18 'cflags!': [ '-Werror', ],
paco 2015/01/14 15:15:58 We're gonna see the errors but we're not treating
Felix Dahlke 2015/02/02 14:12:37 I think it'd make sense to move this right below c
19 }, 20 },
20 }], 21 }],
21 ['OS=="mac"', { 22 ['OS=="mac"', {
22 'xcode_settings': { 23 'xcode_settings': {
23 'CLANG_CXX_LANGUAGE_STANDARD': 'c++0x', 24 'CLANG_CXX_LANGUAGE_STANDARD': 'c++0x',
24 'CLANG_CXX_LIBRARY': 'libstdc++', 25 'CLANG_CXX_LIBRARY': 'libstdc++',
25 'OTHER_CPLUSPLUSFLAGS' : ['-std=c++0x', '-stdlib=libstdc++'], 26 'OTHER_CPLUSPLUSFLAGS' : ['-std=c++0x', '-stdlib=libstdc++'],
26 }, 27 },
27 }], 28 }],
28 ['OS=="android"', { 29 ['OS=="android"', {
29 'target_defaults': { 30 'target_defaults': {
30 'cflags!': [ 31 'cflags!': [
31 '-pthread', # Not supported by Android toolchain. 32 '-pthread', # Not supported by Android toolchain.
32 ], 33 ],
33 'ldflags!': [ 34 'ldflags!': [
34 '-pthread', # Not supported by Android toolchain. 35 '-pthread', # Not supported by Android toolchain.
35 ], 36 ],
36 }, 37 },
37 }], 38 }],
38 ], 39 ],
39 40
40 'target_defaults': { 41 'target_defaults': {
41 'msvs_cygwin_shell': 0, 42 'msvs_cygwin_shell': 0,
42 } 43 }
43 } 44 }
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld