Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: libadblockplus.gyp

Issue 5326829724368896: 1521 - libadblockplus is not compilable on linux x64 (Closed)
Patch Set: Created Jan. 13, 2015, 3:24 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: libadblockplus.gyp
===================================================================
--- a/libadblockplus.gyp
+++ b/libadblockplus.gyp
@@ -19,9 +19,16 @@
'targets': [{
'target_name': 'libadblockplus',
'type': '<(library)',
+ 'direct_dependent_settings':{
Felix Dahlke 2015/01/13 16:51:51 There already is a direct_dependent_settings secti
+ 'defines': [
+ 'werror',
Felix Dahlke 2015/01/13 16:51:51 What exactly is this supposed to do? How I underst
+ ],
+ 'include_dirs': [
+ 'third_party/v8/include',
Felix Dahlke 2015/01/13 16:51:51 This adds the v8 include path to all projects usin
+ ],
+ },
'include_dirs': [
- 'include',
- 'third_party/v8/include',
+ 'include',
Felix Dahlke 2015/01/13 16:51:51 Let's stick to two space indents pleasee.
],
'sources': [
'src/AppInfoJsObject.cpp',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld