Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: chrome/content/ui/filters-filteractions.js

Issue 5331420155215872: Issue #1129 - Disabling filters via space bar does no longer work (Closed)
Patch Set: Created Aug. 6, 2014, 6:21 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 return; 375 return;
376 376
377 let modifiers = 0; 377 let modifiers = 0;
378 if (event.altKey) 378 if (event.altKey)
379 modifiers |= SubscriptionActions._altMask; 379 modifiers |= SubscriptionActions._altMask;
380 if (event.ctrlKey) 380 if (event.ctrlKey)
381 modifiers |= SubscriptionActions._ctrlMask; 381 modifiers |= SubscriptionActions._ctrlMask;
382 if (event.metaKey) 382 if (event.metaKey)
383 modifiers |= SubscriptionActions._metaMask; 383 modifiers |= SubscriptionActions._metaMask;
384 384
385 if (event.charCode == " ".charCodeAt(0) && modifiers == 0 && !E("col-enabled ").hidden) 385 if (event.keyCode == Ci.nsIDOMKeyEvent.DOM_VK_SPACE && modifiers == 0 && !E( "col-enabled").hidden)
386 this.selectionToggleDisabled(); 386 this.selectionToggleDisabled();
387 else if (event.keyCode == Ci.nsIDOMKeyEvent.DOM_VK_UP && modifiers == Subscr iptionActions._accelMask) 387 else if (event.keyCode == Ci.nsIDOMKeyEvent.DOM_VK_UP && modifiers == Subscr iptionActions._accelMask)
388 { 388 {
389 E("filters-moveUp-command").doCommand(); 389 E("filters-moveUp-command").doCommand();
390 event.preventDefault(); 390 event.preventDefault();
391 event.stopPropagation(); 391 event.stopPropagation();
392 } 392 }
393 else if (event.keyCode == Ci.nsIDOMKeyEvent.DOM_VK_DOWN && modifiers == Subs criptionActions._accelMask) 393 else if (event.keyCode == Ci.nsIDOMKeyEvent.DOM_VK_DOWN && modifiers == Subs criptionActions._accelMask)
394 { 394 {
395 E("filters-moveDown-command").doCommand(); 395 E("filters-moveDown-command").doCommand();
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
548 return; 548 return;
549 549
550 this.deleteItems(this.dragItems); 550 this.deleteItems(this.dragItems);
551 } 551 }
552 }; 552 };
553 553
554 window.addEventListener("load", function() 554 window.addEventListener("load", function()
555 { 555 {
556 FilterActions.init(); 556 FilterActions.init();
557 }, false); 557 }, false);
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld