Issue 2628 - Fix stable version of Yandex.Browser listed on the requirements page

globals/get_browser_versions.py

 import re
 import os
 import sys
 import json
 import urllib
 import errno
 import logging
 import time
 from xml.dom import minidom
 
@@ skipping 114 matching lines @@
       get_opera_version('Developer')
     ]
   }
 
 BROWSERS['opera'] = get_opera_versions
 
 def key_by_version(version):
   return map(int, version.split('.'))
 
 def get_yandex_version_raw(suffix, params):
-  response = urllib.urlopen('https://api.browser.yandex.ru/update-info/browser/yandex%s/win-yandex.xml' % (suffix, params))

[Wladimir Palant, 2015/06/03 17:11:36]

If I'm not mistaken this should produce "not all arguments converted during
string formatting" - did you forget %s at the end of the string?

[Sebastian Noack, 2015/06/03 17:42:31]

Argh, you are right. I did test the change, but in case of an error the version
is served from the cache. And with recent changes we don't even get a warning in
the console anymore when it succeeded within the past 2 hours.

+  response = urllib.urlopen('https://api.browser.yandex.ru/update-info/browser/yandex%s/win-yandex.xml%s' % (suffix, params))
   try:
     doc = minidom.parse(response)
   finally:
     response.close()
 
   item = doc.getElementsByTagName('item')[0]
   description = item.getElementsByTagName('description')[0]
   return re.search(r'\d+\.\d+', description.firstChild.nodeValue).group(0)
 
 def get_yandex_version(suffix=''):
   return max(
-    [
-      get_yandex_version_raw(suffix, ''),
-      get_yandex_version_raw(suffix, '?manual=yes'),
-    ],
+    get_yandex_version_raw(suffix, ''),
+    get_yandex_version_raw(suffix, '?manual=yes'),
     key=key_by_version
   )
 
 def get_yandex_versions():
   return {
     'current': get_yandex_version(),
     'unreleased': [get_yandex_version('-beta')]
   }
 
 BROWSERS['yandex'] = get_yandex_versions
@@ skipping 68 matching lines @@
       file.seek(0)
       json.dump(persistent_cache, file)
       file.truncate()
 
   if not versions['previous']:
     logging.warning("Couldn't determine previous browser version, "
                     'please set %s.previous in %s', browser, filename)
 
   cache[browser] = versions
   return versions