Fix the crashing

include/AdblockPlus/V8ValueHolder.h

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 33 matching lines @@
     V8ValueHolder(v8::Isolate* isolate, v8::Persistent<T> value)
     {
       reset(isolate, value);
     }
     V8ValueHolder(v8::Isolate* isolate, v8::Handle<T> value)
     {
       reset(isolate, value);
     }
     ~V8ValueHolder()
     {
-      if (this->value.get())
-      {
-        this->value->Dispose(this->isolate);
-        this->value.reset(0);
-      }
+      reset(isolate, v8::Persistent<T>()); 

[Wladimir Palant, 2014/07/02 09:35:12]

I don't get it, with this change the code seems to be doing effectively the
exact same thing. Could you explain what changed? The only difference I can see
is a temporary v8::Persistent instance.

     }
     void reset(v8::Isolate* isolate, v8::Persistent<T> value)
     {
       if (this->value.get())
       {
         this->value->Dispose(this->isolate);
         this->value.reset(0);
       }
 
       if (!value.IsEmpty())
@@ skipping 20 matching lines @@
     {
       return *value;
     }
   private:
     v8::Isolate* isolate;
     std::auto_ptr<v8::Persistent<T> > value;
   };
 }
 
 #endif