Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5358312170192896: Issue 2076 - Only generate element hiding filters if there are no blocking filters (Closed)

Created:
March 2, 2015, 4:18 p.m. by Sebastian Noack
Modified:
March 3, 2015, 3:02 p.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 2076 - Only generate element hiding filters if there are no blocking filters

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -25 lines) Patch
M lib/filterComposer.js View 3 chunks +24 lines, -25 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
March 2, 2015, 4:19 p.m. (2015-03-02 16:19:14 UTC) #1
kzar
Cool idea, plus I appreciated the improved comments. LGTM
March 2, 2015, 5:29 p.m. (2015-03-02 17:29:57 UTC) #2
Sebastian Noack
On 2015/03/02 17:29:57, kzar wrote: > Cool idea, plus I appreciated the improved comments. LGTM ...
March 2, 2015, 5:33 p.m. (2015-03-02 17:33:25 UTC) #3
Wladimir Palant
March 2, 2015, 7:21 p.m. (2015-03-02 19:21:01 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld