Issue #430 - Filter hit counters aren't cleared

lib/filterStorage.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 337 matching lines @@
     {
       filters = [];
       for (let text in Filter.knownFilters)
         filters.push(Filter.knownFilters[text]);
     }
     for (let filter of filters)
     {
       filter.hitCount = 0;
       filter.lastHit = 0;
     }
+    let {FilterListener} = require("filterListener");

[saroyanm, 2014/06/09 11:28:02]

Called FilterListener module inside of the function for exports.FilterListener
to be already set.

[Wladimir Palant, 2014/06/12 11:58:38]

Actually, hardcoding this logic here doesn't seem too great. FilterStorage is a
generic component, it makes sense that it never uses FilterListener explicitly.
In fact, this logic should be implementable in FilterListener itself, in
onFilterChange:

  if (action == "hitCount" && newValue == 0)
  {
    // Filter hits are being reset, make sure these changes are saved.
    FilterListener.setDirty(0);
  }
  else if (action == "hitCount" || action == "lastHit")
    ...

This will allow some cleanups:

* FilterListener object should no longer be exported, it is an implementation
detail.
* ui.js no longer has to call FilterListener.setDirty(0) explicitly.

[saroyanm, 2014/06/12 16:56:02]

Thanks for idea. 
Done.

+    FilterListener.setDirty(0);
   },
 
   _loading: false,
 
   /**
    * Loads all subscriptions from the disk
    * @param {nsIFile} [sourceFile] File to read from
    */
   loadFromDisk: function(sourceFile)
   {
@@ skipping 520 matching lines @@
       Subscription.knownSubscriptions = origKnownSubscriptions;
     }
 
     // Allow events to be processed every now and then.
     // Note: IO.readFromFile() will deal with the potential reentrance here.
     this.linesProcessed++;
     if (this.linesProcessed % 1000 == 0)
       Utils.yield();
   }
 };