Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5390879414026240: Issue 101 - Fix icon tests (Closed)

Created:
July 28, 2014, 10:19 a.m. by tschuster
Modified:
Aug. 5, 2014, 6:47 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

This fixes the icon tests. I changed the tests so that we only test in newish Firefox version, which have CustomizableUI.jsm.

Patch Set 1 #

Total comments: 1

Patch Set 2 : I tested this with Firefox 24. I think Seamonkey should behave the same. #

Total comments: 2

Patch Set 3 : Force default position for old version and compare to default position to appSupport data #

Patch Set 4 : reverted wrong change, sorry! #

Total comments: 2

Patch Set 5 : fixed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -164 lines) Patch
M chrome/content/tests/ui/icon_position.js View 1 2 3 4 1 chunk +63 lines, -164 lines 0 comments Download

Messages

Total messages: 9
tschuster
July 28, 2014, 10:19 a.m. (2014-07-28 10:19:10 UTC) #1
Wladimir Palant
If addressing my comment below is easy, please do so. Otherwise - LGTM. http://codereview.adblockplus.org/5390879414026240/diff/5629499534213120/chrome/content/tests/ui/icon_position.js File ...
July 30, 2014, 6:04 a.m. (2014-07-30 06:04:51 UTC) #2
tschuster
I tested this with Firefox 24. I think Seamonkey should behave the same.
July 31, 2014, 10:29 a.m. (2014-07-31 10:29:24 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/5390879414026240/diff/5724160613416960/chrome/content/tests/ui/icon_position.js File chrome/content/tests/ui/icon_position.js (right): http://codereview.adblockplus.org/5390879414026240/diff/5724160613416960/chrome/content/tests/ui/icon_position.js#newcode37 chrome/content/tests/ui/icon_position.js:37: const AREA_NAVBAR = usingShim ? "PersonalToolbar" : CustomizableUI.AREA_NAVBAR; Personal ...
July 31, 2014, 10:40 a.m. (2014-07-31 10:40:36 UTC) #4
tschuster
July 31, 2014, 11:13 a.m. (2014-07-31 11:13:05 UTC) #5
tschuster
July 31, 2014, 11:14 a.m. (2014-07-31 11:14:04 UTC) #6
Wladimir Palant
http://codereview.adblockplus.org/5390879414026240/diff/5657382461898752/chrome/content/tests/ui/icon_position.js File chrome/content/tests/ui/icon_position.js (right): http://codereview.adblockplus.org/5390879414026240/diff/5657382461898752/chrome/content/tests/ui/icon_position.js#newcode23 chrome/content/tests/ui/icon_position.js:23: return; This is only relevant when we are using ...
July 31, 2014, 11:36 a.m. (2014-07-31 11:36:14 UTC) #7
tschuster
July 31, 2014, 12:13 p.m. (2014-07-31 12:13:20 UTC) #8
Wladimir Palant
July 31, 2014, 6:32 p.m. (2014-07-31 18:32:59 UTC) #9
LGTM

Powered by Google App Engine
This is Rietveld