Issue 5396553988571136: Issue 2531 - Remove Mozilla-specific about pages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5396553988571136: Issue 2531 - Remove Mozilla-specific about pages (Closed)

Created:
May 15, 2015, 2:05 p.m. by Felix Dahlke

Modified:
May 21, 2015, 11:51 a.m.

Reviewers:
René Jeschke

Visibility:
Public.

Description

Issue 2531 - Remove Mozilla-specific about pages

Patch Set 1 #

Total comments: 1

Created: May 15, 2015, 2:05 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	docshell/base/nsAboutRedirector.cpp	View		3 chunks	+12 lines, -0 lines	0 comments	Download
	M	mobile/android/components/AboutRedirector.js	View		1 chunk	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Felix Dahlke

Unfortunately I haven't found a nicer way of doing this :( Commenting things out in ...

May 15, 2015, 3:22 p.m. (2015-05-15 15:22:18 UTC) #1

René Jeschke

http://codereview.adblockplus.org/5396553988571136/diff/5629499534213120/mobile/android/components/AboutRedirector.js File mobile/android/components/AboutRedirector.js (right): http://codereview.adblockplus.org/5396553988571136/diff/5629499534213120/mobile/android/components/AboutRedirector.js#newcode97 mobile/android/components/AboutRedirector.js:97: for (let moduleName of ["firefox", "fennec", "rights", "apps", "feedback"]) ...

May 18, 2015, 11:36 a.m. (2015-05-18 11:36:51 UTC) #2

Felix Dahlke

On 2015/05/18 11:36:51, René Jeschke wrote: > http://codereview.adblockplus.org/5396553988571136/diff/5629499534213120/mobile/android/components/AboutRedirector.js > File mobile/android/components/AboutRedirector.js (right): > > http://codereview.adblockplus.org/5396553988571136/diff/5629499534213120/mobile/android/components/AboutRedirector.js#newcode97 ...

May 18, 2015, 11:40 a.m. (2015-05-18 11:40:04 UTC) #3

LGTM

Expand All Messages | Collapse All Messages