Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5417256838234112: Issue 2130 - [adblockplus.org Anwiki to CMS migration] Get rid of unconditional sitescripts depende… (Closed)

Created:
March 11, 2015, 8:48 p.m. by Wladimir Palant
Modified:
March 11, 2015, 10:47 p.m.
Reviewers:
kzar
CC:
saroyanm
Visibility:
Public.

Description

Issue 2130 - [adblockplus.org Anwiki to CMS migration] Get rid of unconditional sitescripts depende…

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M filters/get_subscriptions.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
March 11, 2015, 8:48 p.m. (2015-03-11 20:48:38 UTC) #1
kzar
March 11, 2015, 8:54 p.m. (2015-03-11 20:54:01 UTC) #2
Cool I did not realise you could import a module inside a function like that.
Anyway I just double checked at the REPL and you can and it seems to behave like
you describe so this LGTM.

Powered by Google App Engine
This is Rietveld