Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5442569823584256: Issue 189 - Implement API changes from #117, #153, #192 in Chrome (Closed)

Created:
April 14, 2014, 7:31 a.m. by Wladimir Palant
Modified:
April 15, 2014, 1:40 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 189 - Implement API changes from #117, #153, #192 in Chrome

Patch Set 1 #

Patch Set 2 : Fixed calls in IO.copyFile() #

Patch Set 3 : Fixed #301 fallout as well #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -49 lines) Patch
M .hgsubstate View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M background.js View 5 chunks +8 lines, -9 lines 2 comments Download
M lib/filesystem/io.js View 1 3 chunks +4 lines, -19 lines 0 comments Download
M lib/prefs.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/storage/io.js View 1 1 chunk +4 lines, -15 lines 0 comments Download
M lib/utils.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
April 14, 2014, 7:31 a.m. (2014-04-14 07:31:55 UTC) #1
Wladimir Palant
Issue 301 landed in adblockplus and buildtools repositories, I made the necessary adjustments here as ...
April 15, 2014, 7:04 a.m. (2014-04-15 07:04:50 UTC) #2
Thomas Greiner
http://codereview.adblockplus.org/5442569823584256/diff/5757334940811264/background.js File background.js (right): http://codereview.adblockplus.org/5442569823584256/diff/5757334940811264/background.js#newcode67 background.js:67: var importingOldData = importOldData(); Since we can now distinguish ...
April 15, 2014, 12:53 p.m. (2014-04-15 12:53:07 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/5442569823584256/diff/5757334940811264/background.js File background.js (right): http://codereview.adblockplus.org/5442569823584256/diff/5757334940811264/background.js#newcode67 background.js:67: var importingOldData = importOldData(); On 2014/04/15 12:53:07, Thomas Greiner ...
April 15, 2014, 1:31 p.m. (2014-04-15 13:31:52 UTC) #4
Thomas Greiner
April 15, 2014, 1:35 p.m. (2014-04-15 13:35:54 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld