Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5450822905233408: Issue 417 - Reinitializing removed filter lists (Core/Firefox) (Closed)

Created:
May 26, 2014, 10:22 a.m. by Thomas Greiner
Modified:
May 27, 2014, 3:08 p.m.
Visibility:
Public.

Description

Although #417 is Chrome-specific I also included the code for Firefox to handle cases in which patterns.ini is empty and no backups exist. This is not required though so let me know if you think this shouldn't be implemented for Firefox.

Patch Set 1 #

Total comments: 7

Patch Set 2 : Moved check to Platform code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M chrome/content/ui/firstRun.html View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/content/ui/firstRun.js View 1 1 chunk +14 lines, -4 lines 0 comments Download
M chrome/locale/en-US/firstRun.properties View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/skin/firstRun.css View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Thomas Greiner
Although #417 is Chrome-specific I also included the code for Firefox to handle cases in ...
May 26, 2014, 1:33 p.m. (2014-05-26 13:33:04 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/chrome/locale/en-US/firstRun.properties File chrome/locale/en-US/firstRun.properties (right): http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/chrome/locale/en-US/firstRun.properties#newcode6 chrome/locale/en-US/firstRun.properties:6: firstRun_filterlistsReinitializedWarning=We detected an issue causing all filters to be ...
May 26, 2014, 3:08 p.m. (2014-05-26 15:08:46 UTC) #2
Thomas Greiner
http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/chrome/locale/en-US/firstRun.properties File chrome/locale/en-US/firstRun.properties (right): http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/chrome/locale/en-US/firstRun.properties#newcode6 chrome/locale/en-US/firstRun.properties:6: firstRun_filterlistsReinitializedWarning=We detected an issue causing all filters to be ...
May 26, 2014, 5:45 p.m. (2014-05-26 17:45:38 UTC) #3
Wladimir Palant
May 27, 2014, 6:44 a.m. (2014-05-27 06:44:41 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld