Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: safari/ext/popup.js

Issue 5464830253203456: Refactored the abstraction layer to address prerendered pages on Safari caused by leaky abstraction (Closed)
Patch Set: Addressed comments Created April 11, 2014, 2:47 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « safari/ext/content.js ('k') | stats.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: safari/ext/popup.js
===================================================================
--- a/safari/ext/popup.js
+++ b/safari/ext/popup.js
@@ -63,14 +63,12 @@
// import ext into the javascript context of the popover. This code might fail,
// when the background page isn't ready yet. So it is important to put it below
// the reloading code above.
- var backgroundPage = safari.extension.globalPage.contentWindow;
+ window.ext = {
+ __proto__: safari.extension.globalPage.contentWindow.ext,
- window.ext = {
- __proto__: backgroundPage.ext,
closePopup: function()
{
safari.self.hide();
}
};
- window.TabMap = backgroundPage.TabMap;
})();
« no previous file with comments | « safari/ext/content.js ('k') | stats.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld