Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5466750908891136: Reset browser actions on Safari while the tab is loading (Closed)

Created:
Jan. 23, 2014, 10:10 a.m. by Sebastian Noack
Modified:
Jan. 23, 2014, 10:36 a.m.
Visibility:
Public.

Description

Browser actions on Chrome are automatically reset when the tab is loading. So since we just emulate Chrome's behavior on Safari, we also have to take care of reseting browser actions, like Chrome does. This issue was causing the badge not being set to 0, when navigating from a website with blocked ads to a website without blocked ads.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M safari/ext/background.js View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Sebastian Noack
Jan. 23, 2014, 10:14 a.m. (2014-01-23 10:14:58 UTC) #1
Wladimir Palant
Jan. 23, 2014, 10:20 a.m. (2014-01-23 10:20:25 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld