Issue 1601 - Generate blocking filters for all URLs associated with the selected element

include.postload.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 224 matching lines @@
   return urls;
 }
 
 function getURLsFromMediaElement(element)
 {
   var urls = getURLsFromAttributes(element);
 
   for (var i = 0; i < element.children.length; i++)
   {
     var child = element.children[i];
-    if (child.localName != "source" || child.localName != "track")

[Wladimir Palant, 2014/12/08 20:31:09]

This should be == rather than !=, right? Currently this condition is always
true.

[Sebastian Noack, 2014/12/08 21:12:49]

Ouch, you are right. Originally, it was in the form "(.. != .. && .. != ..)
continue;". And I forgot to change the comparison operator as well.

+    if (child.localName == "source" || child.localName == "track")
       urls.push.apply(urls, getURLsFromAttributes(child));

[Wladimir Palant, 2014/12/08 20:31:09]

I think for the <track> element you need to call getURLsFromMediaElement()
recursively.

[Sebastian Noack, 2014/12/08 21:12:49]

If I didn't misread the standard, a <track> element can't have <track> or
<source> child elements. Neither did I find any examples doing that. So why do
you think so?

[Wladimir Palant, 2014/12/09 08:27:21]

It seems that I indeed misunderstood the standard, MDN clearly says that <track>
is an empty element.

   }
 
   if (element.poster)
     urls.push(element.poster);
 
   return urls;
 }
 
 function getURLsFromElement(element) {
   switch (element.localName)
@@ skipping 507 matching lines @@
         break;
       default:
         sendResponse({});
         break;
     }
   });
 
   if (window == window.top)
     ext.backgroundPage.sendMessage({type: "report-html-page"});
 }