Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5519479341580288: Issue 2437 - Update adblockplus dependency to revision 752ffe2eeaf1 (Closed)

Created:
April 29, 2015, 4:44 p.m. by Felix Dahlke
Modified:
May 29, 2015, 7:45 p.m.
Visibility:
Public.

Description

Issue 2437 - Update adblockplus dependency to revision 752ffe2eeaf1

Patch Set 1 #

Total comments: 6

Patch Set 2 : Use an arrow function and Object.defineProperty #

Total comments: 2

Patch Set 3 : Make the properties enumerable #

Patch Set 4 : Run ensure_dependencies.py during the build #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -21 lines) Patch
R .hgsub View 1 chunk +0 lines, -4 lines 0 comments Download
R .hgsubstate View 1 chunk +0 lines, -4 lines 0 comments Download
M README.md View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A dependencies View 1 chunk +6 lines, -0 lines 0 comments Download
A ensure_dependencies.py View 1 chunk +299 lines, -0 lines 0 comments Download
M lib/prefs.js View 1 2 1 chunk +15 lines, -11 lines 0 comments Download
M libadblockplus.gyp View 1 2 3 1 chunk +11 lines, -0 lines 1 comment Download
M test/UpdateCheck.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11
Felix Dahlke
http://codereview.adblockplus.org/5519479341580288/diff/5629499534213120/lib/prefs.js File lib/prefs.js (right): http://codereview.adblockplus.org/5519479341580288/diff/5629499534213120/lib/prefs.js#newcode55 lib/prefs.js:55: Prefs.__defineGetter__(key, function() { return values[key] }); Had to change ...
April 29, 2015, 4:47 p.m. (2015-04-29 16:47:38 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5519479341580288/diff/5629499534213120/README.md File README.md (right): http://codereview.adblockplus.org/5519479341580288/diff/5629499534213120/README.md#newcode12 README.md:12: ./ensure_dependencies.py I still think that this should be part ...
April 29, 2015, 5:42 p.m. (2015-04-29 17:42:56 UTC) #2
Felix Dahlke
New patch set is up. http://codereview.adblockplus.org/5519479341580288/diff/5629499534213120/README.md File README.md (right): http://codereview.adblockplus.org/5519479341580288/diff/5629499534213120/README.md#newcode12 README.md:12: ./ensure_dependencies.py On 2015/04/29 17:42:57, ...
April 30, 2015, 5:06 a.m. (2015-04-30 05:06:11 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/5519479341580288/diff/5757334940811264/lib/prefs.js File lib/prefs.js (right): http://codereview.adblockplus.org/5519479341580288/diff/5757334940811264/lib/prefs.js#newcode71 lib/prefs.js:71: } enumerable: true please, otherwise debugging will be no ...
April 30, 2015, 8:30 a.m. (2015-04-30 08:30:24 UTC) #4
Felix Dahlke
New patch set is up. The discussion regarding how to integrate ensure_dependencies.py (and if we ...
April 30, 2015, 1:17 p.m. (2015-04-30 13:17:38 UTC) #5
Wladimir Palant
I guess you want to make ensure_dependencies.py run by default now?
April 30, 2015, 6:47 p.m. (2015-04-30 18:47:04 UTC) #6
Felix Dahlke
On 2015/04/30 18:47:04, Wladimir Palant wrote: > I guess you want to make ensure_dependencies.py run ...
April 30, 2015, 8:24 p.m. (2015-04-30 20:24:55 UTC) #7
Felix Dahlke
On 2015/04/30 20:24:55, Felix H. Dahlke wrote: > On 2015/04/30 18:47:04, Wladimir Palant wrote: > ...
May 29, 2015, 7:15 a.m. (2015-05-29 07:15:51 UTC) #8
Felix Dahlke
http://codereview.adblockplus.org/5519479341580288/diff/5700735861784576/libadblockplus.gyp File libadblockplus.gyp (right): http://codereview.adblockplus.org/5519479341580288/diff/5700735861784576/libadblockplus.gyp#newcode25 libadblockplus.gyp:25: 'outputs': ['ensure_dependencies_phony_output'], This is kind of ugly, but the ...
May 29, 2015, 7:15 a.m. (2015-05-29 07:15:59 UTC) #9
Wladimir Palant
LGTM
May 29, 2015, 7:24 p.m. (2015-05-29 19:24:33 UTC) #10
René Jeschke
May 29, 2015, 7:34 p.m. (2015-05-29 19:34:39 UTC) #11
LGTM

Powered by Google App Engine
This is Rietveld