Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5535282690523136: Issue 1230 - Remove old social icons from the installer (Closed)

Created:
Nov. 6, 2014, 10:20 a.m. by Felix Dahlke
Modified:
Nov. 7, 2014, 3:03 p.m.
Reviewers:
Oleksandr
CC:
Eric
Visibility:
Public.

Description

Issue 1230 - Remove old social icons from the installer build_release.py failed because the social icons removed by issue 1230 were still used in the installer. Removed them.

Patch Set 1 #

Patch Set 2 : Remove remaining entries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M installer/src/custom-action/test/test-close-application.wxs View 1 1 chunk +0 lines, -3 lines 0 comments Download
M installer/src/msi/adblockplusie.wxs View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5
Felix Dahlke
Nov. 6, 2014, 10:21 a.m. (2014-11-06 10:21:58 UTC) #1
Oleksandr
LGTM
Nov. 6, 2014, 10:22 a.m. (2014-11-06 10:22:59 UTC) #2
Felix Dahlke
Moved Eric to CC, he's not here next week. And I suppose this is simple ...
Nov. 7, 2014, 12:54 p.m. (2014-11-07 12:54:43 UTC) #3
Felix Dahlke
Ouch, left around some old stuff around that killed the devbuilds (although it did build ...
Nov. 7, 2014, 2:40 p.m. (2014-11-07 14:40:27 UTC) #4
Oleksandr
Nov. 7, 2014, 3 p.m. (2014-11-07 15:00:02 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld